Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2448243004:
Change WorkerProcessLauncherTest to use ChannelMojo. (Closed)
|
Created:
4 years, 1 month ago by Sam McNally Modified:
4 years, 1 month ago Reviewers:
joedow CC:
chromium-reviews, chromoting-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange WorkerProcessLauncherTest to use ChannelMojo.
This also fixes a race in WorkerProcessLauncherTest.Crash where the
Crash IPC was received after the fake process had been killed and
relaunched. This caused the new fake process to be unexpectedly killed.
BUG=604282, 659219
Committed: https://crrev.com/7cf811aefdaae1373a2a47c8268be8c201385e72
Cr-Commit-Position: refs/heads/master@{#428191}
Patch Set 1 : https://codereview.chromium.org/2424353002/#ps180001 #Patch Set 2 : #
Total comments: 2
Patch Set 3 : #Messages
Total messages: 23 (17 generated)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
sammc@chromium.org changed reviewers: + joedow@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Change WorkerProcessLauncherTest to use ChannelMojo. This also fixes a race in WorkerProcessLauncherTest.Crash where the Crash IPC was received after the fake process had been killed and relaunched. This caused the new fake process to be unexpectedly killed. BUG=604282 ========== to ========== Change WorkerProcessLauncherTest to use ChannelMojo. This also fixes a race in WorkerProcessLauncherTest.Crash where the Crash IPC was received after the fake process had been killed and relaunched. This caused the new fake process to be unexpectedly killed. BUG=604282,659219 ==========
lgtm https://codereview.chromium.org/2448243004/diff/40001/remoting/host/win/worke... File remoting/host/win/worker_process_launcher_unittest.cc (right): https://codereview.chromium.org/2448243004/diff/40001/remoting/host/win/worke... remoting/host/win/worker_process_launcher_unittest.cc:22: #include "ipc/ipc_message.h" Do you want to IWYU here for the mojo class(es)?
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
https://codereview.chromium.org/2448243004/diff/40001/remoting/host/win/worke... File remoting/host/win/worker_process_launcher_unittest.cc (right): https://codereview.chromium.org/2448243004/diff/40001/remoting/host/win/worke... remoting/host/win/worker_process_launcher_unittest.cc:22: #include "ipc/ipc_message.h" On 2016/10/27 18:41:42, joedow wrote: > Do you want to IWYU here for the mojo class(es)? Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sammc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org Link to the patchset: https://codereview.chromium.org/2448243004/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Change WorkerProcessLauncherTest to use ChannelMojo. This also fixes a race in WorkerProcessLauncherTest.Crash where the Crash IPC was received after the fake process had been killed and relaunched. This caused the new fake process to be unexpectedly killed. BUG=604282,659219 ========== to ========== Change WorkerProcessLauncherTest to use ChannelMojo. This also fixes a race in WorkerProcessLauncherTest.Crash where the Crash IPC was received after the fake process had been killed and relaunched. This caused the new fake process to be unexpectedly killed. BUG=604282,659219 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Change WorkerProcessLauncherTest to use ChannelMojo. This also fixes a race in WorkerProcessLauncherTest.Crash where the Crash IPC was received after the fake process had been killed and relaunched. This caused the new fake process to be unexpectedly killed. BUG=604282,659219 ========== to ========== Change WorkerProcessLauncherTest to use ChannelMojo. This also fixes a race in WorkerProcessLauncherTest.Crash where the Crash IPC was received after the fake process had been killed and relaunched. This caused the new fake process to be unexpectedly killed. BUG=604282,659219 Committed: https://crrev.com/7cf811aefdaae1373a2a47c8268be8c201385e72 Cr-Commit-Position: refs/heads/master@{#428191} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7cf811aefdaae1373a2a47c8268be8c201385e72 Cr-Commit-Position: refs/heads/master@{#428191} |
