Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2448213003: Fix empty title in media notification for recovered page (Closed)

Created:
4 years, 1 month ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 1 month ago
Reviewers:
whywhat
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix empty title in media notification for recovered page BUG=659163 Committed: https://crrev.com/bf9dd03715f0f77bbcd9a500086a09a1c87912f8 Cr-Commit-Position: refs/heads/master@{#427694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Zhiqiang Zhang (Slow)
4 years, 1 month ago (2016-10-26 10:58:06 UTC) #6
whywhat
lgtm can we have a test that would catch that?
4 years, 1 month ago (2016-10-26 14:49:15 UTC) #7
Zhiqiang Zhang (Slow)
On 2016/10/26 14:49:15, whywhat wrote: > lgtm > > can we have a test that ...
4 years, 1 month ago (2016-10-26 15:11:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448213003/1
4 years, 1 month ago (2016-10-26 15:11:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 15:15:34 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 15:44:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf9dd03715f0f77bbcd9a500086a09a1c87912f8
Cr-Commit-Position: refs/heads/master@{#427694}

Powered by Google App Engine
This is Rietveld 408576698