Add UMA to log the size of the Previews opt out DB

Add UMA to log the size of the Previews opt out DB

This logs the number of rows in the Previews opt out DB at profile
startup.

BUG=656739
Committed: https://crrev.com/ee93075a7392ec5d933ac5aa89543ca4822f9c8e
Cr-Commit-Position: refs/heads/master@{#427793}

[RyanSturm, 2016-10-25 17:31:56]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 17:33:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:41:11]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-10-25 19:07:17]

ryansturm@chromium.org changed reviewers:
+ tbansal@chromium.org

[RyanSturm, 2016-10-25 19:07:17]

tbansal: PTAL

[RyanSturm, 2016-10-25 21:01:13]

https://codereview.chromium.org/2448213002/diff/1/components/previews/core/pr...
File components/previews/core/previews_opt_out_store_sql.cc (right):

https://codereview.chromium.org/2448213002/diff/1/components/previews/core/pr...
components/previews/core/previews_opt_out_store_sql.cc:183: // TODO(ryansturm):
Add UMA to log |count|. crbug.com/656739
remove this line

[tbansal1, 2016-10-25 21:05:54]

lgtm % nits.

https://codereview.chromium.org/2448213002/diff/1/components/previews/core/pr...
File components/previews/core/previews_opt_out_store_sql.cc (right):

https://codereview.chromium.org/2448213002/diff/1/components/previews/core/pr...
components/previews/core/previews_opt_out_store_sql.cc:181:
UMA_HISTOGRAM_COUNTS_10000("Previews.OptOutDBRowCount", count);
May be s/Previews.OptOutDBRowCount/Previews.OptOut.DBRowCount/
So all histograms related to opt-out pipeline can have same prefix.

[RyanSturm, 2016-10-25 21:46:06]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 21:46:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-10-25 21:47:08]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 21:47:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-10-25 21:50:23]

ryansturm@chromium.org changed reviewers:
+ asvitkine@chromium.org

[RyanSturm, 2016-10-25 21:50:23]

asvitkine: PTAL @ histograms

https://codereview.chromium.org/2448213002/diff/1/components/previews/core/pr...
File components/previews/core/previews_opt_out_store_sql.cc (right):

https://codereview.chromium.org/2448213002/diff/1/components/previews/core/pr...
components/previews/core/previews_opt_out_store_sql.cc:181:
UMA_HISTOGRAM_COUNTS_10000("Previews.OptOutDBRowCount", count);
On 2016/10/25 21:05:54, tbansal1 wrote:
> May be s/Previews.OptOutDBRowCount/Previews.OptOut.DBRowCount/
> So all histograms related to opt-out pipeline can have same prefix.

Done.

https://codereview.chromium.org/2448213002/diff/1/components/previews/core/pr...
components/previews/core/previews_opt_out_store_sql.cc:183: // TODO(ryansturm):
Add UMA to log |count|. crbug.com/656739
On 2016/10/25 21:01:13, Ryan Sturm wrote:
> remove this line

Done.

[commit-bot: I haz the power, 2016-10-25 22:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 22:56:28]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-10-26 15:16:12]

lgtm

https://codereview.chromium.org/2448213002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2448213002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:47961: +<histogram
name="Previews.OptOut.DBRowCount">
Nit: add units="rows"

[RyanSturm, 2016-10-26 18:16:29]

Thanks for the review!

https://codereview.chromium.org/2448213002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2448213002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:47961: +<histogram
name="Previews.OptOut.DBRowCount">
On 2016/10/26 15:16:12, Alexei Svitkine (slow) wrote:
> Nit: add units="rows"

Done.

[RyanSturm, 2016-10-26 18:16:32]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2016-10-26 18:16:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
tbansal@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2448213002/#ps40001
(title: "asvitkine nits")

[commit-bot: I haz the power, 2016-10-26 18:17:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:15:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 21:17:49]

Description was changed from

==========
Add UMA to log the size of the Previews opt out DB

This logs the number of rows in the Previews opt out DB at profile
startup.

BUG=656739
==========

to

==========
Add UMA to log the size of the Previews opt out DB

This logs the number of rows in the Previews opt out DB at profile
startup.

BUG=656739

Committed: https://crrev.com/ee93075a7392ec5d933ac5aa89543ca4822f9c8e
Cr-Commit-Position: refs/heads/master@{#427793}
==========

[commit-bot: I haz the power, 2016-10-26 21:17:50]

Patchset 3 (id:??) landed as
https://crrev.com/ee93075a7392ec5d933ac5aa89543ca4822f9c8e
Cr-Commit-Position: refs/heads/master@{#427793}