net/http/http_stream_parser.cc - Issue 2448193007: Fix a redundant expression

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/http/http_stream_parser.cc

Issue 2448193007: Fix a redundant expression (Closed)

Patch Set: check request_body_read_buf_ == nullptr Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/http/http_stream_parser.h"	5 #include "net/http/http_stream_parser.h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/compiler_specific.h"	10 #include "base/compiler_specific.h"

(...skipping 1213 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1224	1224

1225 void HttpStreamParser::ValidateStatusLine(const std::string& status_line) {	1225 void HttpStreamParser::ValidateStatusLine(const std::string& status_line) {

1226 HttpStatusLineValidator::StatusLineStatus status =	1226 HttpStatusLineValidator::StatusLineStatus status =

1227 HttpStatusLineValidator::ValidateStatusLine(status_line);	1227 HttpStatusLineValidator::ValidateStatusLine(status_line);

1228 UMA_HISTOGRAM_ENUMERATION("Net.HttpStatusLineStatus", status,	1228 UMA_HISTOGRAM_ENUMERATION("Net.HttpStatusLineStatus", status,

1229 HttpStatusLineValidator::STATUS_LINE_MAX);	1229 HttpStatusLineValidator::STATUS_LINE_MAX);

1230 }	1230 }

1231	1231

1232 bool HttpStreamParser::SendRequestBuffersEmpty() {	1232 bool HttpStreamParser::SendRequestBuffersEmpty() {

1233 return request_headers_ == nullptr && request_body_send_buf_ == nullptr &&	1233 return request_headers_ == nullptr && request_body_send_buf_ == nullptr &&

1234 request_body_send_buf_ == nullptr;	1234 request_body_read_buf_ == nullptr;

1235 }	1235 }

1236	1236

1237 } // namespace net	1237 } // namespace net

OLD	NEW