Fix a redundant expression

net/http/http_stream_parser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_parser.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 1212 matching lines @@
 }
 
 void HttpStreamParser::ValidateStatusLine(const std::string& status_line) {
   HttpStatusLineValidator::StatusLineStatus status =
       HttpStatusLineValidator::ValidateStatusLine(status_line);
   UMA_HISTOGRAM_ENUMERATION("Net.HttpStatusLineStatus", status,
                             HttpStatusLineValidator::STATUS_LINE_MAX);
 }
 
 bool HttpStreamParser::SendRequestBuffersEmpty() {
-  return request_headers_ == nullptr && request_body_send_buf_ == nullptr &&
-         request_body_send_buf_ == nullptr;

[Peter Kasting, 2016/10/27 22:31:36]

Based on line 610, are you sure this wasn't intended to be a check of
|request_body_read_buf_|?

[hans, 2016/10/27 22:39:09]

The name suggests it's intending to check if *send* buffers are empty, but your
pointer to line 610 does make me unsure.

maksims might be able to give a more definite answer.

[maksims (do not use this acc), 2016/10/28 04:53:09]

Oh, that was a typo. It should have been a *read* buffer. Firstly, data is read
from UploadDataStream into *read* buf and then encoded into *send* buff. When
the request is sent, buffers are flushed.

+  return request_headers_ == nullptr && request_body_send_buf_ == nullptr;
 }
 
 }  // namespace net