git cl try: Simplify _get_bucket_map.

git cl try: Simplify _get_bucket_map.

Assuming that assuming bots are always just builder names, and they're never specified along with tests in git cl --bot options, then some logic used for git cl try can be removed.

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/dd49f94cc53abb88b2735c322b37c8408796b926

[qyearsley, 2016-10-27 20:36:05]

qyearsley@chromium.org changed reviewers:
+ tandrii@chromium.org

[qyearsley, 2016-10-27 20:36:06]

https://codereview.chromium.org/2448193006/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2448193006/diff/1/git_cl.py#newcode344
git_cl.py:344: """Returns a dict mapping bucket names to builders and tests,
This could potentially be simplified further to not support listing tests for
each builder. 

This might potentially change behavior though, since
presubmit_support.DoGetTryMasters could return a dict mapping masters to
builders to tests, and in order to not support listing tests, we would change
this to just ignore the tests returned from any GetPreferredTryMasters
functions. Does this sound like something you'd like to do?

[tandrii(chromium), 2016-10-28 15:42:04]

LGTM % (
  nit,
  move "assumption...." into second paragraph in description, so it shorter
title looks better in git log
)

https://codereview.chromium.org/2448193006/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2448193006/diff/1/git_cl.py#newcode344
git_cl.py:344: """Returns a dict mapping bucket names to builders and tests,
On 2016/10/27 20:36:06, qyearsley wrote:
> This could potentially be simplified further to not support listing tests for
> each builder. 
> 
> This might potentially change behavior though, since
> presubmit_support.DoGetTryMasters could return a dict mapping masters to
> builders to tests, and in order to not support listing tests, we would change
> this to just ignore the tests returned from any GetPreferredTryMasters
> functions. Does this sound like something you'd like to do?

Ideally, yes, but there is always a possibility of breaking somebody :(
I've caused too many breakages this year with git cl and my plate is full now. 
I will support you if you want to do it.

https://codereview.chromium.org/2448193006/diff/1/git_cl.py#newcode4854
git_cl.py:4854: # then we default to triggering a dry run (see
http://crbug.com/625697).
s/a dry run/a CQ dry run

[qyearsley, 2016-10-28 18:48:23]

Description was changed from

==========
git cl try: Simplify _get_bucket_map, assuming bots are always just builder
names.
==========

to

==========
git cl try: Simplify _get_bucket_map.

Assuming that assuming bots are always just builder names, and they're never
specified along with tests in git cl --bot options, then some logic used for git
cl try can be removed.
==========

[qyearsley, 2016-10-28 18:49:19]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-10-28 18:49:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2448193006/#ps20001
(title: "Respond to comments")

[commit-bot: I haz the power, 2016-10-28 18:49:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:57:25]

Description was changed from

==========
git cl try: Simplify _get_bucket_map.

Assuming that assuming bots are always just builder names, and they're never
specified along with tests in git cl --bot options, then some logic used for git
cl try can be removed.
==========

to

==========
git cl try: Simplify _get_bucket_map.

Assuming that assuming bots are always just builder names, and they're never
specified along with tests in git cl --bot options, then some logic used for git
cl try can be removed.

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dd49f94cc53abb...
==========

[commit-bot: I haz the power, 2016-10-28 18:57:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dd49f94cc53abb...