Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2448193005: [wrapper-tracing] XMLHttpRequest: Add write barriers (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
Reviewers:
haraken, Marcel Hlopko
CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] XMLHttpRequest: Add write barriers BUG=chromium:468240 R=haraken@chromium.org,hlopko@chromium.org Committed: https://crrev.com/a0225aa6c5ae0c4019abf578db12ffa1e1f3ee25 Cr-Commit-Position: refs/heads/master@{#428005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Lippautz
Another fix.
4 years, 1 month ago (2016-10-27 10:06:16 UTC) #1
haraken
LGTM Instead of relying on the trace-wrapper verifiler, we might want to seriously consider writing ...
4 years, 1 month ago (2016-10-27 10:17:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448193005/1
4 years, 1 month ago (2016-10-27 12:26:51 UTC) #8
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 1 month ago (2016-10-27 12:32:37 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 12:35:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0225aa6c5ae0c4019abf578db12ffa1e1f3ee25
Cr-Commit-Position: refs/heads/master@{#428005}

Powered by Google App Engine
This is Rietveld 408576698