Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2448153002: Fix include path for components grit generated strings. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix include path for components grit generated strings. BUG=None Committed: https://crrev.com/7a7fbd85e128e6bdea7d9acea82cbf29292aac36 Cr-Commit-Position: refs/heads/master@{#427341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ios/chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ssl/ios_ssl_blocking_page.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sdefresne
Please take a look and send to CQ if lgty.
4 years, 1 month ago (2016-10-25 14:07:50 UTC) #4
rohitrao (ping after 24h)
lgtm
4 years, 1 month ago (2016-10-25 14:08:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448153002/1
4 years, 1 month ago (2016-10-25 14:08:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 14:16:38 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 14:18:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a7fbd85e128e6bdea7d9acea82cbf29292aac36
Cr-Commit-Position: refs/heads/master@{#427341}

Powered by Google App Engine
This is Rietveld 408576698