DevTools: add custom-devtools-frontend flag for content shell layout tests

DevTools: add custom-devtools-frontend flag for content shell layout tests

Instead of copying devtools files into the content shell resource folder,
I created a new flag that specifies a custom path to devtools.

BUG=654486
Committed: https://crrev.com/827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b
Cr-Commit-Position: refs/heads/master@{#431949}

[chenwilliam, 2016-10-27 00:08:17]

Description was changed from

==========
DevTools: add devtools-path flag for content shell layout tests

Instead of copying devtools files into the content shell resource folder,
I created a new flag that specifies a custom path to devtools.

Besides using this for "npm test", this can be useful for other cases.

BUG=654486
==========

to

==========
DevTools: add devtools-path flag for content shell layout tests

Instead of copying devtools files into the content shell resource folder,
I created a new flag that specifies a custom path to devtools.

BUG=654486
==========

[chenwilliam, 2016-10-27 00:08:17]

chenwilliam@chromium.org changed reviewers:
+ pfeldman@chromium.org

[chenwilliam, 2016-10-27 00:09:24]

PTAL.

[chenwilliam, 2016-11-01 18:01:12]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2016-11-01 18:01:55]

Dmitry - Could you review this as well since it's related to:
https://codereview.chromium.org/2462153003/

[dgozman, 2016-11-01 18:47:33]

What are the pros versus previous approach?

[chenwilliam, 2016-11-01 18:52:44]

On 2016/11/01 18:47:33, dgozman wrote:
> What are the pros versus previous approach?

This idea was suggested at the team meeting. I think there's two pros:

1. Simplifies running tests so we don't have to copy over devtools files to the
content shell directory. This is a minor speed improvement.
2. Some people such as @allada have requested being able to run an arbitrary
copy of devtools against the content shell for tests. My guess is that people
have multiple checkouts of devtools (e.g. a frontend-only, or multiple full
chromium checkouts) and they're trying to avoid re-compiling the content shell
in these multiple checkouts.

Any concerns?

[dgozman, 2016-11-02 00:54:11]

lgtm

https://codereview.chromium.org/2448143004/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/layout_test_devtools_frontend.cc (right):

https://codereview.chromium.org/2448143004/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/layout_test_devtools_frontend.cc:59:
switches::kDevToolsPath)) {
Let's reuse --custom-devtools-frontend

[chenwilliam, 2016-11-04 22:04:25]

https://codereview.chromium.org/2448143004/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/layout_test_devtools_frontend.cc (right):

https://codereview.chromium.org/2448143004/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/layout_test_devtools_frontend.cc:59:
switches::kDevToolsPath)) {
On 2016/11/02 00:54:11, dgozman wrote:
> Let's reuse --custom-devtools-frontend

Done.

[chenwilliam, 2016-11-04 22:04:33]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-11-04 22:04:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2448143004/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-11-04 22:05:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 22:17:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:17:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-11-14 19:25:24]

lgtm

[chenwilliam, 2016-11-14 19:41:16]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:42:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chenwilliam, 2016-11-14 23:05:02]

Description was changed from

==========
DevTools: add devtools-path flag for content shell layout tests

Instead of copying devtools files into the content shell resource folder,
I created a new flag that specifies a custom path to devtools.

BUG=654486
==========

to

==========
DevTools: add custom-devtools-frontend flag for content shell layout tests

Instead of copying devtools files into the content shell resource folder,
I created a new flag that specifies a custom path to devtools.

BUG=654486
==========

[commit-bot: I haz the power, 2016-11-14 23:09:45]

Description was changed from

==========
DevTools: add custom-devtools-frontend flag for content shell layout tests

Instead of copying devtools files into the content shell resource folder,
I created a new flag that specifies a custom path to devtools.

BUG=654486
==========

to

==========
DevTools: add custom-devtools-frontend flag for content shell layout tests

Instead of copying devtools files into the content shell resource folder,
I created a new flag that specifies a custom path to devtools.

BUG=654486
==========

[commit-bot: I haz the power, 2016-11-14 23:09:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-14 23:12:56]

Description was changed from

==========
DevTools: add custom-devtools-frontend flag for content shell layout tests

Instead of copying devtools files into the content shell resource folder,
I created a new flag that specifies a custom path to devtools.

BUG=654486
==========

to

==========
DevTools: add custom-devtools-frontend flag for content shell layout tests

Instead of copying devtools files into the content shell resource folder,
I created a new flag that specifies a custom path to devtools.

BUG=654486

Committed: https://crrev.com/827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b
Cr-Commit-Position: refs/heads/master@{#431949}
==========

[commit-bot: I haz the power, 2016-11-14 23:12:57]

Patchset 3 (id:??) landed as
https://crrev.com/827a6e34277fa42b81d5fc0f6f7b79e4d017cd7b
Cr-Commit-Position: refs/heads/master@{#431949}