Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/protobuf/BUILD.gn

Issue 2448133006: Tool added to extract network traffic annotations. (Closed)
Patch Set: Comments addressed. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | tools/clang/scripts/run_tool.py » ('j') | tools/clang/traffic_annotation_extractor/traffic_annotation_extractor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/BUILD.gn
diff --git a/third_party/protobuf/BUILD.gn b/third_party/protobuf/BUILD.gn
index 84c916a651e8347ae93661d3056337fe4a060e7d..0bd27fd347ba499e5943ff2d5f69f3ba2c368545 100644
--- a/third_party/protobuf/BUILD.gn
+++ b/third_party/protobuf/BUILD.gn
@@ -177,7 +177,13 @@ component("protobuf_lite") {
# into that category. Do not use in Chrome code.
static_library("protobuf_full") {
# Prevent people from depending on this outside our file.
- visibility = [ ":*" ]
+ visibility = [
+ ":*",
+
+ # Traffic_annotation is not part of the Chrome build.
+ # TODO: This is still problematic and checkdeps complains.
+ "//tools/traffic_annotation/*",
+ ]
sources = protobuf_lite_sources
sources += [
« no previous file with comments | « BUILD.gn ('k') | tools/clang/scripts/run_tool.py » ('j') | tools/clang/traffic_annotation_extractor/traffic_annotation_extractor.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698