tools/clang/traffic_annotation_extractor/tests/README.md - Issue 2448133006: Tool added to extract network traffic annotations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/traffic_annotation_extractor/tests/README.md

Issue 2448133006: Tool added to extract network traffic annotations. (Closed)

Patch Set: Windows compatibility update. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/traffic_annotation_extractor/README.md ('k') | tools/clang/traffic_annotation_extractor/tests/expected_outputs/autofill_core_browser.txt » ('j') | tools/traffic_annotation/auditor/traffic_annotation_auditor.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Manual tests for Traffic Annotation Extractor
	battre 2017/04/20 13:41:03 This testing makes no sense to me. What happens if This testing makes no sense to me. What happens if those two files that are completely out of control of code change? Here is my proposal: 1) Create a file tools/clang/traffic_annotation_extractor/tests/test.cc with all kinds of annotations you can think of. 2) Create a file tools/clang/traffic_annotation_extractor/tests/expected_outputs/test.txt 3) Create a file tools/clang/traffic_annotation_extractor/unittests.py that runs the extraction and verifies that the output matches the expected output. Does that work? Ramin Halavati 2017/04/20 13:53:46 Acknowledged. Show quoted text On 2017/04/20 13:41:03, battre wrote: > This testing makes no sense to me. What happens if those two files that are > completely out of control of code change? > > Here is my proposal: > > 1) Create a file tools/clang/traffic_annotation_extractor/tests/test.cc with all > kinds of annotations you can think of. > 2) Create a file > tools/clang/traffic_annotation_extractor/tests/expected_outputs/test.txt > 3) Create a file tools/clang/traffic_annotation_extractor/unittests.py that runs > the extraction and verifies that the output matches the expected output. > > Does that work? Acknowledged.
	2 This file describes manual sanity tests for traffic annotation extractor. A bug

	3 is filed (will be if you LGTM on delay) to add automatic tests in future.

	4

	5 ## Test:

	6 1. Run `third_party/llvm-build/Release+Asserts/bin/traffic_annotation_extractor

	7 -p out/Debug components/autofill/core/browser/autofill_download_manager.cc >

	8 ~/Desktop/autofill_core_browser.txt`

	9 2. Run `third_party/llvm-build/Release+Asserts/bin/traffic_annotation_extractor

	10 -p out/Debug chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc >

	11 ~/Desktop/bitmap_fetcher_browsertest.txt`

	12 3. Expect the outputs to be similar to the content of 'expected_outputs'

	13

OLD	NEW