Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2448043002: [ignition] Tune code size multiplier. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin, rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy, mythria
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Tune code size multiplier. The interpreter is currently too aggressive in tiering up to TurboFan, especially for (expensive) OSR. Make it slightly less aggressive by choosing a more realistic code size multiplier. R=jarin@chromium.org Committed: https://crrev.com/763dd402b62265aa419cab9ee7e65cd4762a293b Cr-Commit-Position: refs/heads/master@{#40550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/interpreter/interpreter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-10-25 07:45:46 UTC) #1
Jarin
lgtm
4 years, 1 month ago (2016-10-25 07:51:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448043002/1
4 years, 1 month ago (2016-10-25 08:05:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 08:12:18 UTC) #8
rmcilroy
This is so something which should be reviewed by the interpreter team. 32 was originally ...
4 years, 1 month ago (2016-10-25 08:16:30 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:12:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/763dd402b62265aa419cab9ee7e65cd4762a293b
Cr-Commit-Position: refs/heads/master@{#40550}

Powered by Google App Engine
This is Rietveld 408576698