Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2448033004: Remove obsolete plugin-related policies browsertests. (Closed)

Created:
4 years, 1 month ago by pastarmovj
Modified:
4 years, 1 month ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete plugin-related policies browsertests. Those tests were checking obsolete and deprecated behaviour. They were only caught on the official builders because they were noops on Chromium builds. BUG=658860 TEST=Official builders turn green. Committed: https://crrev.com/f091f28ea395ee7486b3c2c9a493c1fe38908dda Cr-Commit-Position: refs/heads/master@{#427369}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove more headers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -225 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 1 6 chunks +0 lines, -225 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pastarmovj
Can I haz review please. :)
4 years, 1 month ago (2016-10-25 14:04:50 UTC) #2
bartfab (slow)
lgtm https://codereview.chromium.org/2448033004/diff/1/chrome/browser/policy/policy_browsertest.cc File chrome/browser/policy/policy_browsertest.cc (left): https://codereview.chromium.org/2448033004/diff/1/chrome/browser/policy/policy_browsertest.cc#oldcode127 chrome/browser/policy/policy_browsertest.cc:127: #include "content/public/browser/browser_child_process_host_iterator.h" Nit: No longer used. https://codereview.chromium.org/2448033004/diff/1/chrome/browser/policy/policy_browsertest.cc#oldcode150 chrome/browser/policy/policy_browsertest.cc:150: ...
4 years, 1 month ago (2016-10-25 15:11:21 UTC) #3
pastarmovj
Done thanks. https://codereview.chromium.org/2448033004/diff/1/chrome/browser/policy/policy_browsertest.cc File chrome/browser/policy/policy_browsertest.cc (left): https://codereview.chromium.org/2448033004/diff/1/chrome/browser/policy/policy_browsertest.cc#oldcode127 chrome/browser/policy/policy_browsertest.cc:127: #include "content/public/browser/browser_child_process_host_iterator.h" On 2016/10/25 15:11:20, bartfab (slow) ...
4 years, 1 month ago (2016-10-25 15:22:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448033004/20001
4 years, 1 month ago (2016-10-25 15:23:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 15:58:29 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 16:14:40 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f091f28ea395ee7486b3c2c9a493c1fe38908dda
Cr-Commit-Position: refs/heads/master@{#427369}

Powered by Google App Engine
This is Rietveld 408576698