Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2448013002: Extract utilities for policy check from ArcAuthService. (Closed)

Created:
4 years, 1 month ago by hidehiko
Modified:
4 years, 1 month ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, khmel+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, khmel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract utilities for policy check from ArcAuthService. This is a preparation to split the policy check from ArcAuthService. BUG=657687 BUG=b/31079732 TEST=Ran trybots. Committed: https://crrev.com/8c1c14bfeca6901d175c90b6ecd846e202f2efcb Cr-Commit-Position: refs/heads/master@{#427359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -17 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 7 chunks +9 lines, -17 lines 0 comments Download
A chrome/browser/chromeos/arc/policy/arc_policy_util.h View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/arc/policy/arc_policy_util.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hidehiko
Luis, this is the CL to address your comment in https://codereview.chromium.org/2446563002/ PTAL.
4 years, 1 month ago (2016-10-25 06:16:05 UTC) #4
Luis Héctor Chávez
lgtm thanks for splitting this up! it makes review so much easier :D
4 years, 1 month ago (2016-10-25 15:26:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448013002/1
4 years, 1 month ago (2016-10-25 15:26:54 UTC) #9
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 1 month ago (2016-10-25 15:35:04 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 15:43:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c1c14bfeca6901d175c90b6ecd846e202f2efcb
Cr-Commit-Position: refs/heads/master@{#427359}

Powered by Google App Engine
This is Rietveld 408576698