[wasm] Debug-time print for compiler graph

src/compiler/graph.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "src/compiler/graph.h"

[Michael Starzinger, 2016/10/25 09:16:03]

nit: Please keep the graph.h include at the top within the graph.cc file as it
was before. This is according to the style guide:

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

[Mircea Trofin, 2016/10/25 15:27:19]

Done.

-
 #include <algorithm>
 
 #include "src/base/bits.h"
+#include "src/compiler/all-nodes.h"
+#include "src/compiler/graph.h"
+#include "src/compiler/node-properties.h"
 #include "src/compiler/node.h"
-#include "src/compiler/node-properties.h"
 #include "src/compiler/verifier.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 Graph::Graph(Zone* zone)
     : zone_(zone),
       start_(nullptr),
       end_(nullptr),
@@ skipping 43 matching lines @@
   return clone;
 }
 
 
 NodeId Graph::NextNodeId() {
   NodeId const id = next_node_id_;
   CHECK(!base::bits::UnsignedAddOverflow32(id, 1, &next_node_id_));
   return id;
 }
 
+void Graph::Print() const {
+  AllNodes all(zone(), this);
+  // Get all the nodes in a map keyed by their ID. That ensures we have them
+  // sorted by ID, which makes it easy to find nodes (e.g. inputs) by their
+  // ID, in the printout.
+  std::map<int, Node*> map;
+  for (Node* node : all.reachable) map.insert(std::make_pair(node->id(), node));
+  for (auto& pair : map) pair.second->Print();

[Michael Starzinger, 2016/10/25 09:16:03]

How would you feel about using "OFStream os(stdout); os << AsRPO(this)" here
instead (probably needs to include graph-visualizer.h then)? That way we would
use the common format people are already used to from other printout and could
avoid having to maintain multiple printing methods.

[Mircea Trofin, 2016/10/25 15:27:19]

Happy to, and done - it is unfortunate the API isn't more discoverable.

+}
+
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8