Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2447973002: CrSearchFieldBehavior: Fix case where infinite 'search-changed' events are fired. (Closed)

Created:
4 years, 1 month ago by dpapad
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, tsergeant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CrSearchFieldBehavior: Fix case where infinite 'search-changed' events are fired. BUG=658954 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1b9eb5729e14ff59468a19095cd35a46dc8eb7cd Cr-Commit-Position: refs/heads/master@{#427431}

Patch Set 1 #

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js View 1 1 chunk +17 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
dpapad
4 years, 1 month ago (2016-10-25 01:31:53 UTC) #9
Dan Beam
can we just use data binding instead?
4 years, 1 month ago (2016-10-25 01:36:20 UTC) #10
dpapad
On 2016/10/25 at 01:36:20, dbeam wrote: > can we just use data binding instead? Binding ...
4 years, 1 month ago (2016-10-25 17:30:38 UTC) #13
Dan Beam
lgtm
4 years, 1 month ago (2016-10-25 18:08:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447973002/40001
4 years, 1 month ago (2016-10-25 18:56:05 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-25 19:04:17 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 19:09:30 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b9eb5729e14ff59468a19095cd35a46dc8eb7cd
Cr-Commit-Position: refs/heads/master@{#427431}

Powered by Google App Engine
This is Rietveld 408576698