Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2447933002: [Devtools] Restructured contextMenu for DataGrid. (Closed)
Patch Set: changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 79afa7694711e9e435a038409ea8c5c947e93eb0..eda27bd79aebafb78b060f9d4f93139a3295b43f 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -391,7 +391,7 @@ WebInspector.NetworkLogView.prototype = {
this._dataGrid.setName("networkLog");
this._dataGrid.setResizeMethod(WebInspector.DataGrid.ResizeMethod.Last);
this._dataGrid.element.classList.add("network-log-grid");
- this._dataGrid.element.addEventListener("contextmenu", this._contextMenu.bind(this), true);
+ this._dataGrid.addEventListener(WebInspector.DataGrid.Events.RowContextMenu, this._onRowContextMenu.bind(this));
this._dataGrid.element.addEventListener("mousedown", this._dataGridMouseDown.bind(this), true);
this._dataGrid.element.addEventListener("mousemove", this._dataGridMouseMove.bind(this), true);
this._dataGrid.element.addEventListener("mouseleave", this._dataGridMouseLeave.bind(this), true);
@@ -913,7 +913,7 @@ WebInspector.NetworkLogView.prototype = {
{
this._timelineHeaderElement = this._timelineWidget.element.createChild("div", "network-timeline-header");
this._timelineHeaderElement.addEventListener("click", timelineHeaderClicked.bind(this));
- this._timelineHeaderElement.addEventListener("contextmenu", this._contextMenu.bind(this));
+ this._timelineHeaderElement.addEventListener("contextmenu", this._columns.headerContextMenuEvent.bind(this._columns));
var innerElement = this._timelineHeaderElement.createChild("div");
innerElement.textContent = WebInspector.UIString("Timeline");
this._timelineColumnSortIcon = this._timelineHeaderElement.createChild("div", "sort-order-icon-container").createChild("div", "sort-order-icon");
@@ -977,25 +977,12 @@ WebInspector.NetworkLogView.prototype = {
},
/**
- * @param {!Event} event
+ * @param {!WebInspector.Event} event
*/
- _contextMenu: function(event)
+ _onRowContextMenu: function(event)
{
- // TODO(allada) Fix datagrid's contextmenu so NetworkLogViewColumns can attach it's own contextmenu event
- if (this._columns.contextMenu(event))
- return;
- var contextMenu = new WebInspector.ContextMenu(event);
-
- var gridNode = this._dataGrid.dataGridNodeFromNode(event.target);
- var request = gridNode && gridNode.request();
-
- /**
- * @param {string} url
- */
- function openResourceInNewTab(url)
- {
- InspectorFrontendHost.openInNewTab(url);
- }
+ var contextMenu = /** @type {!WebInspector.ContextMenu} */ (event.data.contextMenu);
+ var request = (/** @type {!WebInspector.DataGridNode} */ (event.data.node)).request();
contextMenu.appendApplicableItems(request);
var copyMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Copy"));

Powered by Google App Engine
This is Rietveld 408576698