Extract _ReferencedUris information from UnlinkedUnit.

Extract _ReferencedUris information from UnlinkedUnit.

I considered removing it altogether, but reading unlinked bundles costs
something. So, we might consider caching this graph information.

OTOH, I agree that we might want to delay adding caching until we solve
the extra invalidation problem in _verifyUnlinkedSignatureOfChangedFiles.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/581e6bc6e1395c0c7d0b630a243db7e224d78d99

[scheglov, 2016-10-24 21:05:49]

Description was changed from

==========
Extract _ReferencedUris information from UnlinkedUnit.

I considered removing it altogether, but reading unlinked bundles costs
something. So, we might consider caching this graph information.

OTOH, I agree that we might want to delay adding caching until we solve
the extra invalidation problem in _verifyUnlinkedSignatureOfChangedFiles.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Extract _ReferencedUris information from UnlinkedUnit.

I considered removing it altogether, but reading unlinked bundles costs
something. So, we might consider caching this graph information.

OTOH, I agree that we might want to delay adding caching until we solve
the extra invalidation problem in _verifyUnlinkedSignatureOfChangedFiles.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/581e6bc6e1395c0c7d0b630a243db7e224d78d99
==========

[scheglov, 2016-10-24 21:05:50]

Committed patchset #1 (id:1) manually as
581e6bc6e1395c0c7d0b630a243db7e224d78d99 (presubmit successful).

[Brian Wilkerson, 2016-10-26 07:21:31]

lgtm

[Paul Berry, 2016-10-31 15:56:56]

lgtm

https://codereview.chromium.org/2447903002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2447903002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:585: * TODO(scheglov) I see that
adding a local var changes (full) API signature.
Do you have a repro for this?  If you'd rather spend your time on other things,
I'd be glad to investigate--feel free to file a bug in the issue tracker.

Note that I fixed some bugs which would cause this in
84ec7f01c060ee0a5e423c58a11707a4e3a60045 and
105f568452fa562207ce6fbc557bb7638024cc69.  Perhaps there are still some
outstanding problems :(

[scheglov, 2016-10-31 16:03:16]

https://codereview.chromium.org/2447903002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2447903002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:585: * TODO(scheglov) I see that
adding a local var changes (full) API signature.
On 2016/10/31 15:56:56, Paul Berry wrote:
> Do you have a repro for this?  If you'd rather spend your time on other
things,
> I'd be glad to investigate--feel free to file a bug in the issue tracker.
> 
> Note that I fixed some bugs which would cause this in
> 84ec7f01c060ee0a5e423c58a11707a4e3a60045 and
> 105f568452fa562207ce6fbc557bb7638024cc69.  Perhaps there are still some
> outstanding problems :(

Adding a local variable per se is not a problem.
But I suspect that are two, possibly related problems with API signatures.

1. They are order sensitive, i.e. "class A{} class B {}" and "class B {} class A
{}" are different.

2. When you add a variable that is that first one referencing a type, the type
is added to UnlinkedUnit.references, and so changes the signature. Or if you
reorder local variables, these type references are also reordered, and the
signature changes.

[Paul Berry, 2016-10-31 21:46:37]

On 2016/10/31 16:03:16, scheglov wrote:
>
https://codereview.chromium.org/2447903002/diff/1/pkg/analyzer/lib/src/dart/a...
> File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):
> 
>
https://codereview.chromium.org/2447903002/diff/1/pkg/analyzer/lib/src/dart/a...
> pkg/analyzer/lib/src/dart/analysis/driver.dart:585: * TODO(scheglov) I see
that
> adding a local var changes (full) API signature.
> On 2016/10/31 15:56:56, Paul Berry wrote:
> > Do you have a repro for this?  If you'd rather spend your time on other
> things,
> > I'd be glad to investigate--feel free to file a bug in the issue tracker.
> > 
> > Note that I fixed some bugs which would cause this in
> > 84ec7f01c060ee0a5e423c58a11707a4e3a60045 and
> > 105f568452fa562207ce6fbc557bb7638024cc69.  Perhaps there are still some
> > outstanding problems :(
> 
> Adding a local variable per se is not a problem.
> But I suspect that are two, possibly related problems with API signatures.
> 
> 1. They are order sensitive, i.e. "class A{} class B {}" and "class B {} class
A
> {}" are different.

Ok, this is a known issue and IMHO not worth worrying about.  (We could sort the
declarations but the references would still be out of order; sorting them too
would be a lot of work, and I think we'd be better off working on other
incrementality ideas that are more general).

> 
> 2. When you add a variable that is that first one referencing a type, the type
> is added to UnlinkedUnit.references, and so changes the signature. Or if you
> reorder local variables, these type references are also reordered, and the
> signature changes.

Aha, I hadn't thought of this case.  I've filed a ticket at
https://github.com/dart-lang/sdk/issues/27708 to track it, and assigned it to
myself.