src/codec/SkGifCodec.h - Issue 2447863002: Report repetition count in SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkGifCodec.h

Issue 2447863002: Report repetition count in SkCodec (Closed)

Patch Set: Return a bool, with multiple out parameters Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkGifCodec.h

diff --git a/src/codec/SkGifCodec.h b/src/codec/SkGifCodec.h

index b5f8f7ce0c48958685f96d8592e3e94be22892bc..da853e5775100275e3009aab391ebc2f8bc38cfc 100644

--- a/src/codec/SkGifCodec.h

+++ b/src/codec/SkGifCodec.h

@@ -48,7 +48,7 @@ protected:

uint64_t onGetFillValue(const SkImageInfo&) const override;

- std::vector<FrameInfo> onGetFrameInfo() override;

+ bool onGetFrameInfo(std::vector<FrameInfo>*, int*) override;

Result onStartIncrementalDecode(const SkImageInfo& /*dstInfo*/, void*, size_t,

const SkCodec::Options&, SkPMColor*, int*) override;