Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2447853002: Use SequencedWorkerPoolOwner in MemoryDumpManagerTest. (Closed)

Created:
4 years, 1 month ago by fdoray
Modified:
4 years, 1 month ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SequencedWorkerPoolOwner in MemoryDumpManagerTest. MemoryDumpManagerTest didn't join its thread. This made a write in TearDown() racy with a read from a thread created by the test. With this CL, threads created by MemoryDumpManagerTest are joined before TearDown() runs. BUG=658766 Committed: https://crrev.com/42bdd9c57551be778bfda66453cb6054d78dfdac Cr-Commit-Position: refs/heads/master@{#427251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M base/test/sequenced_worker_pool_owner.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/sequenced_worker_pool_owner.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
fdoray
PTAL
4 years, 1 month ago (2016-10-24 20:06:29 UTC) #2
danakj
LGTM
4 years, 1 month ago (2016-10-24 20:29:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447853002/1
4 years, 1 month ago (2016-10-24 20:31:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/93240)
4 years, 1 month ago (2016-10-24 20:41:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447853002/1
4 years, 1 month ago (2016-10-24 20:42:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/93245)
4 years, 1 month ago (2016-10-24 20:51:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447853002/1
4 years, 1 month ago (2016-10-25 01:06:46 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 02:46:26 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 02:49:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42bdd9c57551be778bfda66453cb6054d78dfdac
Cr-Commit-Position: refs/heads/master@{#427251}

Powered by Google App Engine
This is Rietveld 408576698