Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2447843002: Revert "Allow to set display "inline" on legend element" (Closed)

Created:
4 years, 1 month ago by Gleb Lanbin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, blink-reviews-layout_chromium.org, rwlbuis, Tab Atkins
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Allow to set display "inline" on legend element" This reverts commit 2383abb8b227d12ae53f2b163b57e02ff63dbf0b. Reason: it violates the spec that says that fieldset's legend should be displayed as a block box (overriding any explicit 'display' value). Also it introduces an interop issue with Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=653870. BUG=481983 Committed: https://crrev.com/07a1644e65e23598796babe8056dba9a986f3c33 Cr-Commit-Position: refs/heads/master@{#427364}

Patch Set 1 #

Messages

Total messages: 26 (21 generated)
Gleb Lanbin
4 years, 1 month ago (2016-10-24 21:51:32 UTC) #17
mstensho (USE GERRIT)
lgtm - spec: https://html.spec.whatwg.org/multipage/rendering.html#rendered-legend
4 years, 1 month ago (2016-10-25 07:51:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447843002/20001
4 years, 1 month ago (2016-10-25 15:43:10 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-10-25 15:47:29 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 16:14:29 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07a1644e65e23598796babe8056dba9a986f3c33
Cr-Commit-Position: refs/heads/master@{#427364}

Powered by Google App Engine
This is Rietveld 408576698