Pretty print CERT_CT_COMPLIANCE_CHECKED events in the NetLog viewer.

Pretty print CERT_CT_COMPLIANCE_CHECKED events in the NetLog viewer.

In net-internals's events viewer, certificates attached to CERT_CT_COMPLIANCE_CHECKED events are now properly pretty-printed instead of being printed all in one line.

BUG=628690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8f0859349b48a31b0317096f5a5cd8931b629fcc
Cr-Commit-Position: refs/heads/master@{#427572}

[wangyix, 2016-10-24 16:57:50]

Description was changed from

==========
certificates attached to CERT_CT_COMPLIANCE_CHECKED are now pretty-printed.

BUG=628690
==========

to

==========
certificates attached to CERT_CT_COMPLIANCE_CHECKED are now pretty-printed.

BUG=628690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[wangyix, 2016-10-24 22:42:38]

wangyix@google.com changed reviewers:
+ eroman@chromium.org, mmenke@chromium.org

[mmenke, 2016-10-25 15:08:07]

LGTM

https://codereview.chromium.org/2447803002/diff/1/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/log_view_painter.js (right):

https://codereview.chromium.org/2447803002/diff/1/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/log_view_painter.js:277: function
getParamaterWriterForEventType(eventType) {
While you're here, could you fix the spelling of this function and the one call
to it, which is also in this file (Paramater -> Parameter)

[eroman, 2016-10-25 20:33:45]

LGTM after:

 (1) Adding an accompanying unit-test for log_view_painter.js.
 (2) Changing the change description

For the change description, for inspiration take a look at
  $ git log

Stylistically, Chromium code tends to describe commits (change lists) directly
in terms of an action in the present tense:

  Add pre-generated private keys 
  Make TextPrompt autocomplete element private
  Convert some callers of ScriptContext::CallFunction
  Roll recipe dependencies
  Escape non-ASCII Request header values before...
  Update the broken links in function comments...

I suggest matching that style in your changes. For instance how about:

Pretty print CERT_CT_COMPLIANCE_CHECKED events in the NetLog viewer.

[wangyix, 2016-10-25 20:41:16]

Description was changed from

==========
certificates attached to CERT_CT_COMPLIANCE_CHECKED are now pretty-printed.

BUG=628690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Pretty print CERT_CT_COMPLIANCE_CHECKED events in the NetLog viewer.

In net-internals's events viewer, certificates attached to
CERT_CT_COMPLIANCE_CHECKED events are now properly pretty-printed instead of
being printed all in one line.

BUG=628690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[wangyix, 2016-10-26 00:46:12]

The CQ bit was checked by wangyix@google.com

[wangyix, 2016-10-26 00:46:12]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org,
eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2447803002/#ps40001
(title: "added accompanying unit-test")

[commit-bot: I haz the power, 2016-10-26 00:46:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 01:46:07]

Description was changed from

==========
Pretty print CERT_CT_COMPLIANCE_CHECKED events in the NetLog viewer.

In net-internals's events viewer, certificates attached to
CERT_CT_COMPLIANCE_CHECKED events are now properly pretty-printed instead of
being printed all in one line.

BUG=628690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Pretty print CERT_CT_COMPLIANCE_CHECKED events in the NetLog viewer.

In net-internals's events viewer, certificates attached to
CERT_CT_COMPLIANCE_CHECKED events are now properly pretty-printed instead of
being printed all in one line.

BUG=628690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-26 01:46:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 01:49:55]

Description was changed from

==========
Pretty print CERT_CT_COMPLIANCE_CHECKED events in the NetLog viewer.

In net-internals's events viewer, certificates attached to
CERT_CT_COMPLIANCE_CHECKED events are now properly pretty-printed instead of
being printed all in one line.

BUG=628690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Pretty print CERT_CT_COMPLIANCE_CHECKED events in the NetLog viewer.

In net-internals's events viewer, certificates attached to
CERT_CT_COMPLIANCE_CHECKED events are now properly pretty-printed instead of
being printed all in one line.

BUG=628690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8f0859349b48a31b0317096f5a5cd8931b629fcc
Cr-Commit-Position: refs/heads/master@{#427572}
==========

[commit-bot: I haz the power, 2016-10-26 01:49:56]

Patchset 3 (id:??) landed as
https://crrev.com/8f0859349b48a31b0317096f5a5cd8931b629fcc
Cr-Commit-Position: refs/heads/master@{#427572}