Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2447783002:
[ignition] Use more-targeted check for CONST-this-initialization hole check (Closed)
Description[ignition] Use more-targeted check for CONST-this-initialization hole check
This brings the BytecodeGenerator in line with FullCodeGenerator, now that
more requests for hole checks are flowing through BuildVariableAssignment.
BUG=chromium:658528
Committed: https://crrev.com/56626f302d7d29f05ca19cf6d79666c9aabceca7
Cr-Commit-Position: refs/heads/master@{#40557}
Patch Set 1 #Patch Set 2 : Rebased #Patch Set 3 : Fix the interpreter instead of the parser #
Messages
Total messages: 24 (15 generated)
The CQ bit was checked by adamk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11394) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
Apparently the asm.js validator depends on this information...not sure how I feel about that, but it doesn't seem _totally_ unreasonable. You can hold off on reviewing for now.
Description was changed from ========== Only use Token::INIT for lexically scoped variable declarations Since var declarations desugar "var x = <init>" to var x; x = <init>; we don't actually know that this as "initializing" assignment (moreover, there's no such thing for vars, which are initialized to undefined). Using Token::ASSIGN in that case lets us avoid a DCHECK in code that expects to skip hole checks for all Token::INIT assignments to lexically-declared variables other than "this". R=neis@chromium.org BUG=chromium:658528 ========== to ========== [ignition] Use more-targeted check for CONST-this-initialization hole check This brings the BytecodeGenerator in line with FullCodeGenerator, now that more requests for hole checks are flowing through BuildVariableAssignment. BUG=chromium:658528 ==========
adamk@chromium.org changed reviewers: + rmcilroy@chromium.org - neis@chromium.org
Different, more minimal approach, PTAL
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by adamk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [ignition] Use more-targeted check for CONST-this-initialization hole check This brings the BytecodeGenerator in line with FullCodeGenerator, now that more requests for hole checks are flowing through BuildVariableAssignment. BUG=chromium:658528 ========== to ========== [ignition] Use more-targeted check for CONST-this-initialization hole check This brings the BytecodeGenerator in line with FullCodeGenerator, now that more requests for hole checks are flowing through BuildVariableAssignment. BUG=chromium:658528 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [ignition] Use more-targeted check for CONST-this-initialization hole check This brings the BytecodeGenerator in line with FullCodeGenerator, now that more requests for hole checks are flowing through BuildVariableAssignment. BUG=chromium:658528 ========== to ========== [ignition] Use more-targeted check for CONST-this-initialization hole check This brings the BytecodeGenerator in line with FullCodeGenerator, now that more requests for hole checks are flowing through BuildVariableAssignment. BUG=chromium:658528 Committed: https://crrev.com/56626f302d7d29f05ca19cf6d79666c9aabceca7 Cr-Commit-Position: refs/heads/master@{#40557} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/56626f302d7d29f05ca19cf6d79666c9aabceca7 Cr-Commit-Position: refs/heads/master@{#40557} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
