Use setSequentialFocusNavigationStartingPoint in ChromeVox

chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
index 6f30e143b6fdb635f46da820675d7670785e62e9..834fbbb6e809f137bcbfe65dc0b4b045eb21064e 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
@@ -765,19 +765,39 @@ Background.prototype = {
     var isFocusable = function(node) {
       return node.role != RoleType.iframe &&
           node.state.focusable &&
-          !node.state.focused &&
           !AutomationPredicate.structuralContainer(node);
     };
+
+    // First, try to focus the start or end node.
     if (isFocusable(start)) {
-      start.focus();
+      if (!start.state.focused)
+        start.focus();
       return;
-    }
-    if (isFocusable(end)) {
-      end.focus();
+    } else if (isFocusable(end)) {
+      if (!end.state.focused)
+        end.focus();
       return;
     }
 
-    // TODO(dmazzoni): Set sequential focus.
+    // Next, see if an ancestor of both |start| and |end| is focusable.
+    var startAncestors = AutomationUtil.getAncestors(start);
+    var endAncestors = AutomationUtil.getAncestors(end);
+    var commonAncestorCount = (start == end ? startAncestors.length :
+        AutomationUtil.getDivergence(startAncestors, endAncestors));

[David Tseng, 2016/10/27 01:09:50]

As mentioned, AutomationUtil.getLeastCommonAncestor and then walk up.

[dmazzoni, 2016/10/27 06:27:27]

Done.

+
+    for (var i = commonAncestorCount - 1; i >= 0; --i) {

[David Tseng, 2016/10/27 01:09:50]

Thanks for doing this, but I don't really like the way this looks after
reconsidering.
- focusing root web areas blurs focus
- this messes up tab order. Example:
Suppose you have a toolbar (focusable) with 3 items. Two buttons and a text node
in that order. Object nav to the text. This would trigger a focus on the
toolbar. Tabbing at that point would move starting from the toolbar and onto the
first button. This goes for just about anything that's focusable with
descendants that are also focusable.

[dmazzoni, 2016/10/27 03:59:25]

OK, what if we limit it to just links, and text fields?

I think if you navigate to content inside of a link or inside
of a contenteditable I'd expect it to get focus.

I understand your concern about containers like toolbars, so maybe we could
just special-case the roles that make sense.

[dmazzoni, 2016/10/27 06:27:27]

Switched to just links within the same frame, that seem reasonable?

+      var ancestor = startAncestors[i];
+      if (isFocusable(ancestor)) {
+        if (!ancestor.state.focused)
+          ancestor.focus();
+        return;
+      }
+    }
+
+    // If nothing is focusable, set the sequential focus navigation starting
+    // point, which ensures that the next time you press Tab, you'll reach
+    // the next or previous focusable node from |start|.
+    start.setSequentialFocusNavigationStartingPoint();
   }
 };