chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 2447773002: Use setSequentialFocusNavigationStartingPoint in ChromeVox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 2447773002: Use setSequentialFocusNavigationStartingPoint in ChromeVox (Closed)

Patch Set: Rebased and added test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js ('k') | chrome/browser/ui/aura/accessibility/automation_manager_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index 6f30e143b6fdb635f46da820675d7670785e62e9..4159fb6904e97b624752ac70e2e4edb608b14fd3 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -770,14 +770,11 @@ Background.prototype = {

};

if (isFocusable(start)) {

start.focus();

- return;

- }

- if (isFocusable(end)) {

+ } else if (isFocusable(end)) {

end.focus();

- return;

+ } else {

+ start.setSequentialFocusNavigationStartingPoint();

David Tseng 2016/10/26 17:03:26 Does this work on in line text boxes?

}

- // TODO(dmazzoni): Set sequential focus.

}

};