Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2447773002: Use setSequentialFocusNavigationStartingPoint in ChromeVox (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 2151 matching lines...) Expand 10 before | Expand all | Expand 10 after
2162 void AXNodeObject::decrement() { 2162 void AXNodeObject::decrement() {
2163 UserGestureIndicator gestureIndicator( 2163 UserGestureIndicator gestureIndicator(
2164 UserGestureToken::create(UserGestureToken::NewGesture)); 2164 UserGestureToken::create(UserGestureToken::NewGesture));
2165 alterSliderValue(false); 2165 alterSliderValue(false);
2166 } 2166 }
2167 2167
2168 void AXNodeObject::setSequentialFocusNavigationStartingPoint() { 2168 void AXNodeObject::setSequentialFocusNavigationStartingPoint() {
2169 if (!getNode()) 2169 if (!getNode())
2170 return; 2170 return;
2171 2171
2172 getNode()->document().clearFocusedElement();
David Tseng 2016/10/24 21:51:32 Will this result in any ax events?
dmazzoni 2016/10/26 16:20:22 Yes, but the existing mechanism you added suppress
David Tseng 2016/10/26 17:03:26 Great, so you didn't get any repeated text/odd foc
2172 getNode()->document().setSequentialFocusNavigationStartingPoint(getNode()); 2173 getNode()->document().setSequentialFocusNavigationStartingPoint(getNode());
2173 } 2174 }
2174 2175
2175 void AXNodeObject::childrenChanged() { 2176 void AXNodeObject::childrenChanged() {
2176 // This method is meant as a quick way of marking a portion of the 2177 // This method is meant as a quick way of marking a portion of the
2177 // accessibility tree dirty. 2178 // accessibility tree dirty.
2178 if (!getNode() && !getLayoutObject()) 2179 if (!getNode() && !getLayoutObject())
2179 return; 2180 return;
2180 2181
2181 // If this is not part of the accessibility tree because an ancestor 2182 // If this is not part of the accessibility tree because an ancestor
(...skipping 779 matching lines...) Expand 10 before | Expand all | Expand 10 after
2961 } 2962 }
2962 return placeholder; 2963 return placeholder;
2963 } 2964 }
2964 2965
2965 DEFINE_TRACE(AXNodeObject) { 2966 DEFINE_TRACE(AXNodeObject) {
2966 visitor->trace(m_node); 2967 visitor->trace(m_node);
2967 AXObject::trace(visitor); 2968 AXObject::trace(visitor);
2968 } 2969 }
2969 2970
2970 } // namespace blink 2971 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698