[wasm] Add a new fuzzer which can also test wasm function calls.

[wasm] Add a new fuzzer which can also test wasm function calls.

Depending on the inputs the fuzzer creates multiple functions. These
functions can have signatures with an int32 return value and up to three
parameters of type int32, int64, float32, or float64.

R=titzer@chromium.org, clemensh@chromium.org

Committed: https://crrev.com/f8414ead48c0972c913d868c6ba2f1171517159a
Cr-Commit-Position: refs/heads/master@{#40530}

[ahaas, 2016-10-24 09:26:59]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 09:27:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 09:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 09:36:49]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Clemens Hammacher, 2016-10-24 09:44:43]

lgtm, with two comments:
- the test/fuzzer/wasm_call/foo file can be removed
- we should check at some point which of our fuzzers are redundant.

[ahaas, 2016-10-24 09:47:52]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 09:47:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 11:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 11:05:50]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-10-24 11:07:31]

I CL desc: These function(+s)

[ahaas, 2016-10-24 11:10:08]

Description was changed from

==========
[wasm] Add a new fuzzer which can also test wasm function calls.

Depending on the inputs the fuzzer creates multiple functions. These
function can have a signature with an int32 return value and up to three
parameters of type int32, int64, float32, or float64.

R=titzer@chromium.org, clemensh@chromium.org
==========

to

==========
[wasm] Add a new fuzzer which can also test wasm function calls.

Depending on the inputs the fuzzer creates multiple functions. These
functions can have signatures with an int32 return value and up to three
parameters of type int32, int64, float32, or float64.

R=titzer@chromium.org, clemensh@chromium.org
==========

[ahaas, 2016-10-24 11:11:14]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-10-24 11:11:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
clemensh@chromium.org
Link to the patchset: https://codereview.chromium.org/2447643002/#ps20001
(title: "sign unsigned mismatch")

[commit-bot: I haz the power, 2016-10-24 11:11:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 11:14:43]

Committed patchset #2 (id:20001)

[titzer, 2016-10-24 11:17:21]

https://codereview.chromium.org/2447643002/diff/20001/test/fuzzer/wasm-call.cc
File test/fuzzer/wasm-call.cc (right):

https://codereview.chromium.org/2447643002/diff/20001/test/fuzzer/wasm-call.c...
test/fuzzer/wasm-call.cc:35: V result = *reinterpret_cast<const V*>(*data);
This is not going to work on platforms that don't support misaligned access.

https://codereview.chromium.org/2447643002/diff/20001/test/fuzzer/wasm-call.c...
test/fuzzer/wasm-call.cc:96: LocalType types[] = {kAstF32, kAstF64, kAstI32,
kAstI64};
Why not just make this global and remove WASM_FUZZER_TYPE*

[ahaas, 2016-10-24 12:07:55]

On 2016/10/24 at 09:44:43, clemensh wrote:
> lgtm, with two comments:
> - the test/fuzzer/wasm_call/foo file can be removed

The files in this directory are needed to test the fuzzer on the try-bots. If
the directory is empty, the fuzzer is not tested. That's why there is one file
in this directory.

> - we should check at some point which of our fuzzers are redundant.

Yes. I do take a look at the fuzzers regularly.

[ahaas, 2016-10-24 12:10:33]

I fixed the remaining issues in https://codereview.chromium.org/2444863002

https://codereview.chromium.org/2447643002/diff/20001/test/fuzzer/wasm-call.cc
File test/fuzzer/wasm-call.cc (right):

https://codereview.chromium.org/2447643002/diff/20001/test/fuzzer/wasm-call.c...
test/fuzzer/wasm-call.cc:35: V result = *reinterpret_cast<const V*>(*data);
On 2016/10/24 at 11:17:21, titzer wrote:
> This is not going to work on platforms that don't support misaligned access.

Done.

https://codereview.chromium.org/2447643002/diff/20001/test/fuzzer/wasm-call.c...
test/fuzzer/wasm-call.cc:96: LocalType types[] = {kAstF32, kAstF64, kAstI32,
kAstI64};
On 2016/10/24 at 11:17:21, titzer wrote:
> Why not just make this global and remove WASM_FUZZER_TYPE*

I used the WASM_FUZZER_TYPE* definitions to give names to the type in
{add_argument}. I achieve that now by passing a LocalType to {add_argument}.

[commit-bot: I haz the power, 2016-11-17 22:10:57]

Description was changed from

==========
[wasm] Add a new fuzzer which can also test wasm function calls.

Depending on the inputs the fuzzer creates multiple functions. These
functions can have signatures with an int32 return value and up to three
parameters of type int32, int64, float32, or float64.

R=titzer@chromium.org, clemensh@chromium.org
==========

to

==========
[wasm] Add a new fuzzer which can also test wasm function calls.

Depending on the inputs the fuzzer creates multiple functions. These
functions can have signatures with an int32 return value and up to three
parameters of type int32, int64, float32, or float64.

R=titzer@chromium.org, clemensh@chromium.org

Committed: https://crrev.com/f8414ead48c0972c913d868c6ba2f1171517159a
Cr-Commit-Position: refs/heads/master@{#40530}
==========

[commit-bot: I haz the power, 2016-11-17 22:10:58]

Patchset 2 (id:??) landed as
https://crrev.com/f8414ead48c0972c913d868c6ba2f1171517159a
Cr-Commit-Position: refs/heads/master@{#40530}