Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2447633002: Convert LayoutTests/svg/dom/SVGAnimatedEnumeration*.html js-tests.js to testharness.js based tests. (Closed)

Created:
4 years, 1 month ago by Shanmuga Pandi
Modified:
4 years, 1 month ago
Reviewers:
Srirama, fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert LayoutTests/svg/dom/SVGAnimatedEnumeration*.html js-tests.js to testharness.js based tests. BUG=636710 Committed: https://crrev.com/33868a91cb83a2081b4ae559c74063cf25755e90 Cr-Commit-Position: refs/heads/master@{#428299}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -744 lines) Patch
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html View 1 chunk +113 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt View 1 chunk +0 lines, -97 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html View 1 chunk +71 lines, -11 lines 2 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html View 1 chunk +71 lines, -11 lines 2 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html View 1 chunk +40 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html View 1 chunk +71 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGMarkerElement.js View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGMaskElement.js View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGPatternElement.js View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextContentElement.js View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextPathElement.js View 1 chunk +0 lines, -73 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Shanmuga Pandi
PTAL
4 years, 1 month ago (2016-10-24 09:01:48 UTC) #2
Srirama
lgtm https://codereview.chromium.org/2447633002/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html File third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html (left): https://codereview.chromium.org/2447633002/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html#oldcode9 third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html:9: <script src="script-tests/SVGAnimatedEnumeration-SVGPatternElement.js"></script> It is referring SVGPatterElement here instead ...
4 years, 1 month ago (2016-10-27 11:12:17 UTC) #3
Srirama
+fs
4 years, 1 month ago (2016-10-27 11:13:03 UTC) #5
fs
lgtm https://codereview.chromium.org/2447633002/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html File third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html (left): https://codereview.chromium.org/2447633002/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html#oldcode9 third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html:9: <script src="script-tests/SVGAnimatedEnumeration-SVGPatternElement.js"></script> On 2016/10/27 at 11:12:17, Srirama_OOO_till_6thNov wrote: ...
4 years, 1 month ago (2016-10-27 13:07:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447633002/1
4 years, 1 month ago (2016-10-28 05:43:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 06:42:40 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 06:45:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33868a91cb83a2081b4ae559c74063cf25755e90
Cr-Commit-Position: refs/heads/master@{#428299}

Powered by Google App Engine
This is Rietveld 408576698