Remove ImageObserver::didDraw()

Remove ImageObserver::didDraw()

Follow-up of https://codereview.chromium.org/2411243004/.
didDraw() no longer does anything.

BUG=603462
Committed: https://crrev.com/950d4f8dae0d4011896719a973eaebba757b5828
Cr-Commit-Position: refs/heads/master@{#433881}

[hiroshige, 2016-10-24 05:47:54]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 05:48:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 06:04:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 06:04:53]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hiroshige, 2016-10-24 10:36:23]

Description was changed from

==========
Remove ImageObserver::didDraw()

BUG=
==========

to

==========
Remove ImageObserver::didDraw()

Follow-up of https://codereview.chromium.org/2411243004/.
didDraw() no longer does something.

BUG=603462
==========

[hiroshige, 2016-10-24 10:36:43]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, yhirano@chromium.org

[f(malita), 2016-10-24 12:20:41]

fmalita@chromium.org changed reviewers:
+ fmalita@chromium.org

[f(malita), 2016-10-24 12:20:42]

Nice, LGTM!

https://codereview.chromium.org/2447623002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
(left):

https://codereview.chromium.org/2447623002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp:2883:
if (!packPixels(reinterpret_cast<const uint8_t*>(pixels), sourceFormat, width,
Nit: return packPixels(...);

[Nate Chapin, 2016-10-24 17:12:28]

LGTM.

Nit: s/something/anything/ in the patch description.

[yhirano, 2016-10-25 01:54:11]

lgtm

[hiroshige, 2016-11-16 09:32:22]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 09:32:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 09:57:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 09:57:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[hiroshige, 2016-11-18 06:01:07]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 06:01:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-18 06:05:46]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-11-18 06:06:44]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 06:07:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 06:09:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 06:09:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2016-11-22 12:23:40]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[hiroshige, 2016-11-22 12:23:54]

Description was changed from

==========
Remove ImageObserver::didDraw()

Follow-up of https://codereview.chromium.org/2411243004/.
didDraw() no longer does something.

BUG=603462
==========

to

==========
Remove ImageObserver::didDraw()

Follow-up of https://codereview.chromium.org/2411243004/.
didDraw() no longer does anything.

BUG=603462
==========

[commit-bot: I haz the power, 2016-11-22 12:23:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-22 12:24:15]

> Nit: s/something/anything/ in the patch description.
Done.

https://codereview.chromium.org/2447623002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
(left):

https://codereview.chromium.org/2447623002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp:2883:
if (!packPixels(reinterpret_cast<const uint8_t*>(pixels), sourceFormat, width,
On 2016/10/24 12:20:42, f(malita) wrote:
> Nit: return packPixels(...);

Done.

[commit-bot: I haz the power, 2016-11-22 13:56:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 13:56:09]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-22 16:27:04]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-11-22 16:27:05]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
fmalita@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2447623002/#ps80001
(title: "Rebawse")

[commit-bot: I haz the power, 2016-11-22 16:27:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 16:30:55]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1479832024785330,
"parent_rev": "74c7c0a787b523529a53239fa3aec2bc37147fb7", "commit_rev":
"97d077a238d3ca4c3ff8809c32ca9c2d534f1066"}

[commit-bot: I haz the power, 2016-11-22 16:31:22]

Description was changed from

==========
Remove ImageObserver::didDraw()

Follow-up of https://codereview.chromium.org/2411243004/.
didDraw() no longer does anything.

BUG=603462
==========

to

==========
Remove ImageObserver::didDraw()

Follow-up of https://codereview.chromium.org/2411243004/.
didDraw() no longer does anything.

BUG=603462
==========

[commit-bot: I haz the power, 2016-11-22 16:31:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-22 16:33:57]

Description was changed from

==========
Remove ImageObserver::didDraw()

Follow-up of https://codereview.chromium.org/2411243004/.
didDraw() no longer does anything.

BUG=603462
==========

to

==========
Remove ImageObserver::didDraw()

Follow-up of https://codereview.chromium.org/2411243004/.
didDraw() no longer does anything.

BUG=603462

Committed: https://crrev.com/950d4f8dae0d4011896719a973eaebba757b5828
Cr-Commit-Position: refs/heads/master@{#433881}
==========

[commit-bot: I haz the power, 2016-11-22 16:33:58]

Patchset 5 (id:??) landed as
https://crrev.com/950d4f8dae0d4011896719a973eaebba757b5828
Cr-Commit-Position: refs/heads/master@{#433881}