Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2447613004: Mojoify PoweMonitorMessageBroadcaster IPC from browser to child process (Closed)

Created:
4 years, 1 month ago by ke.he
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojoify PoweMonitorMessageBroadcaster IPC from browser to child process Mojoify PoweMonitorMessageBroadcaster is the first step of "Decoupling Power Monitor from //Content". PowerMonitorMessageBroadcaster sends messages to both RenderProcess and other ChildProcess. This CL Mojoifies the messages PowerMonitorMsg_PowerStateChange, PowerMonitorMsg_Suspend, and PowerMonitorMsg_Resume. To do so we introduce the PowerMonitorClient Mojo interface and change the PowerMonitorBroadcastSource to implement the interface. To avoid setting PowerMonitorClientPtr separately in {child,render}_process_ host_impl.cc, we add the PowerMonitorClientRegister mojo interface, and add the BrowserChildProcessHost::ConnectionFilterImpl so it can register the mojo interface implementation in BrowserChildProcessHostImpl side. Unit tests for PowerMonitorMessageBroadcaster and PowerMonitorBroadcastSource are changed accordingly. Followup will decouple PowerMonitorMessageBroadcaster and PowerMonitorBroadcastSource from //Content. BUG=647247

Patch Set 1 #

Patch Set 2 : Mojoify PoweMonitorMessageBroadcaster IPC from browser to child process #

Patch Set 3 : Mojoify PoweMonitorMessageBroadcaster IPC from browser to child process #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -210 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_child_process_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 6 chunks +26 lines, -3 lines 0 comments Download
M content/browser/power_monitor_message_broadcaster.h View 1 1 chunk +10 lines, -9 lines 0 comments Download
M content/browser/power_monitor_message_broadcaster.cc View 1 3 chunks +21 lines, -9 lines 0 comments Download
M content/browser/power_monitor_message_broadcaster_unittest.cc View 3 chunks +32 lines, -37 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/child/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M content/child/power_monitor_broadcast_source.h View 1 2 1 chunk +11 lines, -18 lines 0 comments Download
M content/child/power_monitor_broadcast_source.cc View 1 2 1 chunk +10 lines, -77 lines 0 comments Download
M content/child/power_monitor_broadcast_source_unittest.cc View 2 chunks +9 lines, -18 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/power_monitor_messages.h View 1 chunk +0 lines, -26 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 2 chunks +7 lines, -2 lines 0 comments Download
M content/public/browser/browser_child_process_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + device/power_monitor/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + device/power_monitor/public/interfaces/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A device/power_monitor/public/interfaces/power_monitor.mojom View 1 1 chunk +22 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698