Include linked hashes into the current file state.

Include linked hashes into the current file state.

Also put the file content into the AnalysisContext to avoid race
condition if the file content is being changed.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/64c776d30d9d01e5170428281fbf825b3723e235

[scheglov, 2016-10-24 03:59:44]

Description was changed from

==========
Include linked hashes into the current file state.

Also put the file content into the AnalysisContext to avoid race
condition if the file content is being changed.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Include linked hashes into the current file state.

Also put the file content into the AnalysisContext to avoid race
condition if the file content is being changed.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/64c776d30d9d01e5170428281fbf825b3723e235
==========

[scheglov, 2016-10-24 03:59:45]

Committed patchset #1 (id:1) manually as
64c776d30d9d01e5170428281fbf825b3723e235 (presubmit successful).

[Paul Berry, 2016-10-24 11:51:47]

lgtm

https://codereview.chromium.org/2447603002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2447603002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:138: final _linkedHashMap = <Uri,
String>{};
My comments about nomenclature from the last patch apply here too.  Consider
renaming to something like "_dependencyHashMap".

https://codereview.chromium.org/2447603002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:330: //       
_logger.runTimed('Computed resolved unit', () {
Why is this code commented out?  Either remove or add a TODO comment.

[scheglov, 2016-10-24 17:44:37]

https://codereview.chromium.org/2447603002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2447603002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:138: final _linkedHashMap = <Uri,
String>{};
On 2016/10/24 11:51:47, Paul Berry wrote:
> My comments about nomenclature from the last patch apply here too.  Consider
> renaming to something like "_dependencyHashMap".

Acknowledged.
I renamed them together.

https://codereview.chromium.org/2447603002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:330: //       
_logger.runTimed('Computed resolved unit', () {
On 2016/10/24 11:51:47, Paul Berry wrote:
> Why is this code commented out?  Either remove or add a TODO comment.

We don't actually compute full analysis results yet.
Will implement soon.

[Brian Wilkerson, 2016-10-26 06:33:36]

lgtm