Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 2447583002: [devil] Work around occasionally fatal `adb forward --list` bug. (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 1 month ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[devil] Work around occasionally fatal `adb forward --list` bug. Additional context: b/31811775 BUG=chromium:623989 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/984fd95d0458d37eff56be2f4195223ffc18dfa3

Patch Set 1 #

Patch Set 2 : remove extra line #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M devil/devil/android/sdk/adb_wrapper.py View 1 1 chunk +13 lines, -0 lines 2 comments Download
M telemetry/telemetry/internal/platform/android_platform_backend.py View 1 chunk +4 lines, -16 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
4 years, 2 months ago (2016-10-24 02:37:23 UTC) #2
nednguyen
lgtm https://codereview.chromium.org/2447583002/diff/20001/devil/devil/android/sdk/adb_wrapper.py File devil/devil/android/sdk/adb_wrapper.py (right): https://codereview.chromium.org/2447583002/diff/20001/devil/devil/android/sdk/adb_wrapper.py#newcode651 devil/devil/android/sdk/adb_wrapper.py:651: # once b/31811775 is fixed. Should we remove ...
4 years, 1 month ago (2016-10-24 12:05:50 UTC) #3
jbudorick
https://codereview.chromium.org/2447583002/diff/20001/devil/devil/android/sdk/adb_wrapper.py File devil/devil/android/sdk/adb_wrapper.py (right): https://codereview.chromium.org/2447583002/diff/20001/devil/devil/android/sdk/adb_wrapper.py#newcode651 devil/devil/android/sdk/adb_wrapper.py:651: # once b/31811775 is fixed. On 2016/10/24 12:05:50, nednguyen ...
4 years, 1 month ago (2016-10-24 13:46:16 UTC) #4
nednguyen
On 2016/10/24 13:46:16, jbudorick wrote: > https://codereview.chromium.org/2447583002/diff/20001/devil/devil/android/sdk/adb_wrapper.py > File devil/devil/android/sdk/adb_wrapper.py (right): > > https://codereview.chromium.org/2447583002/diff/20001/devil/devil/android/sdk/adb_wrapper.py#newcode651 > ...
4 years, 1 month ago (2016-10-24 13:54:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447583002/20001
4 years, 1 month ago (2016-10-24 13:56:17 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 14:19:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698