Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 2447563003: [Telemetry] Remove logic of pulling out user_agent_type from page_set (Closed)

Created:
4 years, 1 month ago by nednguyen
Modified:
4 years, 1 month ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M telemetry/telemetry/page/shared_page_state.py View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
nednguyen
4 years, 1 month ago (2016-10-24 23:41:10 UTC) #2
aiolos (Not reviewing)
yay! lgtm
4 years, 1 month ago (2016-10-24 23:46:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447563003/1
4 years, 1 month ago (2016-10-24 23:47:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7aa9328a154ab90699470e084506c437c7426685
4 years, 1 month ago (2016-10-25 00:01:57 UTC) #10
nednguyen(REVIEW IN OTHER ACC)
4 years, 1 month ago (2016-10-25 12:26:29 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2451713003/ by nednguyen@chromium.org.

The reason for reverting is: Cause failure on waterfall..

Powered by Google App Engine
This is Rietveld 408576698