chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc - Issue 2447553003: More pre-MD odds and ends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

Issue 2447553003: More pre-MD odds and ends. (Closed)

Patch Set: fix mac Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension_action/action_info.cc ('K') | « chrome/common/extensions/api/extension_action/action_info.cc ('k') | extensions/browser/extension_icon_placeholder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

index 4a0b6f984c3528cfa3324c8896b14239653a8939..85df2cb32f05bf2cf9a699729f6845ca01ddc63b 100644

--- a/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

@@ -81,8 +81,7 @@ TEST_F(PageActionManifestTest, LoadPageActionHelper) {

// No title, so fall back to name.

ASSERT_EQ(name, action->default_title);

ASSERT_EQ(img1,

- action->default_icon.Get(extension_misc::EXTENSION_ICON_ACTION,

- ExtensionIconSet::MATCH_EXACTLY));

+ action->default_icon.Get(19, ExtensionIconSet::MATCH_EXACTLY));

// Same test with explicitly set type.

action = LoadAction("page_action_type.json");