More pre-MD odds and ends.

extensions/common/constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_CONSTANTS_H_
 #define EXTENSIONS_COMMON_CONSTANTS_H_
 
 #include "base/files/file_path.h"
 #include "ui/base/layout.h"
 
@@ skipping 170 matching lines @@
 
 // Matches chrome.tabs.TAB_ID_NONE.
 const int kUnknownTabId = -1;
 
 // Matches chrome.windows.WINDOW_ID_NONE.
 const int kUnknownWindowId = -1;
 
 // Matches chrome.windows.WINDOW_ID_CURRENT.
 const int kCurrentWindowId = -2;
 
-// NOTE: If you change this list, you should also change kExtensionIconSizes
-// in cc file.
 enum ExtensionIcons {
   EXTENSION_ICON_GIGANTOR = 512,
   EXTENSION_ICON_EXTRA_LARGE = 256,
   EXTENSION_ICON_LARGE = 128,
   EXTENSION_ICON_MEDIUM = 48,
   EXTENSION_ICON_SMALL = 32,
   EXTENSION_ICON_SMALLISH = 24,
-  EXTENSION_ICON_ACTION = 19,

[Devlin, 2016/11/02 00:52:12]

I think I'd prefer we keep this, and just update it to also be 16. 
Conceptually, it's use remains the same - it's the size of the extension action
in the toolbar.

[Evan Stade, 2016/11/02 13:14:05]

I think that creates a mismatch between this value, which describes a semantic
usage, and the rest of the values in this enum, which are ambivalent about how
they're applied. The logical connection between 16 and extension actions is
provided by ExtensionAction::ActionIconSize().

Nevertheless, done.

[Devlin, 2016/11/02 23:16:52]

You've convinced me.  For some reason in the original patch, I swear I saw more
usages of ICON_BITTY than of using ExtensionAction::ActionIconSize().

   EXTENSION_ICON_BITTY = 16,
   EXTENSION_ICON_INVALID = 0,
 };
 
 // The extension id of the PDF extension.
 extern const char kPdfExtensionId[];
 
 // The extension id of the Office Viewer component extension.
 extern const char kQuickOfficeComponentExtensionId[];
 
 // The extension id of the Office Viewer extension on the internal webstore.
 extern const char kQuickOfficeInternalExtensionId[];
 
 // The extension id of the Office Viewer extension.
 extern const char kQuickOfficeExtensionId[];
 
 // The extension id used for testing mimeHandlerPrivate.
 extern const char kMimeHandlerPrivateTestExtensionId[];
 
 // The extension id for the production version of Hangouts.
 extern const char kProdHangoutsExtensionId[];
 
 // Extension ids used by Hangouts.
 extern const char* const kHangoutsExtensionIds[6];
 
 }  // namespace extension_misc
 
 #endif  // EXTENSIONS_COMMON_CONSTANTS_H_