Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 2447523002: [ash-md] Added different highlighting modes to the InkDropImpl. (Closed)
Patch Set: Fixed InkDropHostView::GetInkDrop() to use CreateInkDrop(). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/button/toggle_button.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/combobox/combobox.cc
diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc
index 2acc7354c757cb20bdaff53d219504e68644a39b..852aa5f0fddaa56ee1501cb98c99d538f8f57163 100644
--- a/ui/views/controls/combobox/combobox.cc
+++ b/ui/views/controls/combobox/combobox.cc
@@ -30,6 +30,7 @@
#include "ui/resources/grit/ui_resources.h"
#include "ui/views/animation/flood_fill_ink_drop_ripple.h"
#include "ui/views/animation/ink_drop_highlight.h"
+#include "ui/views/animation/ink_drop_impl.h"
#include "ui/views/background.h"
#include "ui/views/controls/button/custom_button.h"
#include "ui/views/controls/button/label_button.h"
@@ -141,6 +142,12 @@ class TransparentButton : public CustomButton {
}
// Overridden from InkDropHost:
+ std::unique_ptr<InkDrop> CreateInkDrop() override {
+ std::unique_ptr<views::InkDropImpl> ink_drop = CreateDefaultInkDropImpl();
+ ink_drop->SetShowHighlightOnHover(false);
+ return std::move(ink_drop);
+ }
+
std::unique_ptr<InkDropRipple> CreateInkDropRipple() const override {
return std::unique_ptr<views::InkDropRipple>(
new views::FloodFillInkDropRipple(
@@ -150,10 +157,6 @@ class TransparentButton : public CustomButton {
ink_drop_visible_opacity()));
}
- std::unique_ptr<InkDropHighlight> CreateInkDropHighlight() const override {
- return nullptr;
- }
-
private:
DISALLOW_COPY_AND_ASSIGN(TransparentButton);
};
« no previous file with comments | « ui/views/controls/button/toggle_button.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698