Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: ui/views/controls/button/custom_button.h

Issue 2447523002: [ash-md] Added different highlighting modes to the InkDropImpl. (Closed)
Patch Set: Fixed InkDropHostView::GetInkDrop() to use CreateInkDrop(). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/button/checkbox.cc ('k') | ui/views/controls/button/custom_button.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/custom_button.h
diff --git a/ui/views/controls/button/custom_button.h b/ui/views/controls/button/custom_button.h
index 54dbd5d32035f236507515b2e51c39ff70100c44..36eee0ebe27e4148da06587ab6a29f9e24ea2e58 100644
--- a/ui/views/controls/button/custom_button.h
+++ b/ui/views/controls/button/custom_button.h
@@ -109,7 +109,9 @@ class VIEWS_EXPORT CustomButton : public Button, public gfx::AnimationDelegate {
void OnDragDone() override;
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
void VisibilityChanged(View* starting_from, bool is_visible) override;
- std::unique_ptr<InkDropHighlight> CreateInkDropHighlight() const override;
+
+ // Overridden from InkDropHostView:
+ std::unique_ptr<InkDrop> CreateInkDrop() override;
SkColor GetInkDropBaseColor() const override;
// Overridden from gfx::AnimationDelegate:
@@ -119,7 +121,6 @@ class VIEWS_EXPORT CustomButton : public Button, public gfx::AnimationDelegate {
void ViewHierarchyChanged(
const ViewHierarchyChangedDetails& details) override;
void OnBlur() override;
- bool ShouldShowInkDropForFocus() const override;
protected:
// Construct the Button with a Listener. See comment for Button's ctor.
@@ -140,9 +141,6 @@ class VIEWS_EXPORT CustomButton : public Button, public gfx::AnimationDelegate {
// we simply return IsTriggerableEvent(event).
virtual bool ShouldEnterPushedState(const ui::Event& event);
- // Returns true if highlight effect should be visible.
- virtual bool ShouldShowInkDropHighlight() const;
-
void set_has_ink_drop_action_on_click(bool has_ink_drop_action_on_click) {
has_ink_drop_action_on_click_ = has_ink_drop_action_on_click;
}
« no previous file with comments | « ui/views/controls/button/checkbox.cc ('k') | ui/views/controls/button/custom_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698