chrome/browser/ui/views/toolbar/toolbar_action_view.h - Issue 2447523002: [ash-md] Added different highlighting modes to the InkDropImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.h

Issue 2447523002: [ash-md] Added different highlighting modes to the InkDropImpl. (Closed)

Patch Set: Fixed InkDropHostView::GetInkDrop() to use CreateInkDrop(). Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/toolbar_action_view.h

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.h b/chrome/browser/ui/views/toolbar/toolbar_action_view.h

index ad20695269b4ea6844b1597e8b0580e2bfb6a5d5..79163e2701bbdbc50cc0116e4a1f56791f4a9cd4 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.h

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.h

@@ -74,7 +74,7 @@ class ToolbarActionView : public views::MenuButton,

const override;

bool IsTriggerableEvent(const ui::Event& event) override;

SkColor GetInkDropBaseColor() const override;

- bool ShouldShowInkDropHighlight() const override;

+ std::unique_ptr<views::InkDrop> CreateInkDrop() override;

// ToolbarActionViewDelegateViews:

content::WebContents* GetCurrentWebContents() const override;