Log the size of each of the stores and complete DB on launch and after each

components/safe_browsing_db/v4_protocol_manager_util.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_PROTOCOL_MANAGER_UTIL_H_
 #define COMPONENTS_SAFE_BROWSING_DB_V4_PROTOCOL_MANAGER_UTIL_H_
 
 // A class that implements the stateless methods used by the GetHashUpdate and
 // GetFullHash stubby calls made by Chrome using the SafeBrowsing V4 protocol.
 
@@ skipping 175 matching lines @@
 
   // Identical operation already pending.
   ALREADY_PENDING_ERROR = 6,
 
   // Memory space for histograms is determined by the max.  ALWAYS
   // ADD NEW VALUES BEFORE THIS ONE.
   OPERATION_RESULT_MAX = 7
 };
 
 // A class that provides static methods related to the Pver4 protocol.
+// TODO(vakh): Consider making this class a namespace instead.
+// TODO(vakh): Re-order the methods in alphabetical order.
 class V4ProtocolManagerUtil {
  public:
   // Canonicalizes url as per Google Safe Browsing Specification.
   // See: https://developers.google.com/safe-browsing/v4/urls-hashing
   static void CanonicalizeUrl(const GURL& url,
                               std::string* canonicalized_hostname,
                               std::string* canonicalized_path,
                               std::string* canonicalized_query);
 
   // This method returns the host suffix combinations from the hostname in the
@@ skipping 51 matching lines @@
 
   static bool FullHashToSmallestHashPrefix(const FullHash& full_hash,
                                            HashPrefix* hash_prefix);
 
   static bool FullHashMatchesHashPrefix(const FullHash& full_hash,
                                         const HashPrefix& hash_prefix);
 
   static void SetClientInfoFromConfig(ClientInfo* client_info,
                                       const V4ProtocolConfig& config);
 
+  // Returns the size of the file at |file_path|, or 0 if there's an error.
+  static int64_t GetFileSizeOrZero(const base::FilePath& file_path);

[Nathan Parker, 2016/10/24 20:33:54]

Are you using this in v4?  If not, why move it?

[vakh (use Gerrit instead), 2016/10/24 22:04:50]

I was. Then shess@ pointed out that I don't need to. Reverted.

+
  private:
   V4ProtocolManagerUtil(){};
   FRIEND_TEST_ALL_PREFIXES(V4ProtocolManagerUtilTest, TestBackOffLogic);
   FRIEND_TEST_ALL_PREFIXES(V4ProtocolManagerUtilTest,
                            TestGetRequestUrlAndUpdateHeaders);
   FRIEND_TEST_ALL_PREFIXES(V4ProtocolManagerUtilTest, UrlParsing);
   FRIEND_TEST_ALL_PREFIXES(V4ProtocolManagerUtilTest, CanonicalizeUrl);
 
   // Composes a URL using |prefix|, |method| (e.g.: encodedFullHashes).
   // |request_base64|, |client_id|, |version| and |key_param|. |prefix|
@@ skipping 49 matching lines @@
 
 template <>
 struct hash<safe_browsing::ListIdentifier> {
   std::size_t operator()(const safe_browsing::ListIdentifier& id) const {
     return id.hash();
   }
 };
 }
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_V4_PROTOCOL_MANAGER_UTIL_H_