Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2447413003: Write out useful Android GN vars in a non-gradle-specific form. (Closed)

Created:
4 years, 1 month ago by agrieve
Modified:
4 years, 1 month ago
Reviewers:
michaelbai
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Write out useful Android GN vars in a non-gradle-specific form. My intention is to use these variables in our downstream release scripts rather than hardcoding the location of the active android sdk. BUG=623989 Committed: https://crrev.com/1f83518dc187930a5bf43665b2b0f7d885bbd1b3 Cr-Commit-Position: refs/heads/master@{#428380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M build/android/BUILD.gn View 1 chunk +10 lines, -10 lines 0 comments Download
M build/android/gradle/generate_gradle.py View 6 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
agrieve
On 2016/10/27 15:14:28, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:michaelbai@chromium.org 🎃
4 years, 1 month ago (2016-10-27 15:14:44 UTC) #3
michaelbai
lgtm
4 years, 1 month ago (2016-10-27 19:40:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447413003/1
4 years, 1 month ago (2016-10-27 20:37:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/169442)
4 years, 1 month ago (2016-10-27 22:22:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447413003/1
4 years, 1 month ago (2016-10-28 14:56:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 15:36:08 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 15:49:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f83518dc187930a5bf43665b2b0f7d885bbd1b3
Cr-Commit-Position: refs/heads/master@{#428380}

Powered by Google App Engine
This is Rietveld 408576698