Fix flaky ImeTest#testGetCursorCapsMode

Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This isn't needed, and it causes flakiness.
We can avoid that by using textarea instead.

BUG=651704
Committed: https://crrev.com/7569ed80092216c303fb3838167583626c6ef03d
Cr-Commit-Position: refs/heads/master@{#427954}

[yabinh, 2016-10-26 09:49:21]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 09:49:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-10-26 09:56:19]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 09:56:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-10-26 10:01:28]

Description was changed from

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when we press enter key on inputbox on
a phone, we will open a blank tab. This is not what we wanted, and it
causes flakniss. We can avoid that by using textarea instead.

BUG=651704
==========

to

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, whnen enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is not what we wanted, and it
causes flakniss. We can avoid that by using textarea instead.

BUG=651704
==========

[yabinh, 2016-10-26 10:02:14]

Description was changed from

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, whnen enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is not what we wanted, and it
causes flakniss. We can avoid that by using textarea instead.

BUG=651704
==========

to

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, whnen enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is not what we want, and it
causes flakniss. We can avoid that by using textarea instead.

BUG=651704
==========

[yabinh, 2016-10-26 10:02:14]

yabinh@chromium.org changed reviewers:
+ aelias@chromium.org, changwan@chromium.org

[commit-bot: I haz the power, 2016-10-26 10:16:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 10:16:23]

Dry run: This issue passed the CQ dry run.

[yabinh, 2016-10-26 10:30:36]

When ImeTest#commitText("\n") runs on input_text element, a blank tab will be
open.  Also, ImeTest#commitText() will send a ViewHostMsg_TextInputStateChanged
message.It's a long call stack. It takes some time from opening the tab to
sending the message.


Case#1: If the time is long enough,
InputMethodController#frame().selection().rootEditableElement() will be null,
thus textInputInfo.type will be WebTextInputTypeNone. Later, when we update the
keyboard visibility, we will hide the keyboard and restart input. On doing that,
we will create an inputConnection unblocked on UI Thread. Since it's unblocked,
TextInputState#blockAndGetStateUpdate will return null. That's why
getCursorCapsMode returns 0.


Case#2: Sometimes, the time is short. Then
InputMethodController#frame().selection().rootEditableElement() hasn't changed
to be null, everything will be fine.


If we don't open the blank tab, we can avoid the flakiness. Besides, opening a
blank tab is not needed at the beginning.

https://codereview.chromium.org/2447333003/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/2447333003/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:1439:

Make sure Ime Thread is enabled.
See https://bugs.chromium.org/p/chromium/issues/detail?id=648482#c5

[yabinh, 2016-10-26 10:38:56]

Description was changed from

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, whnen enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is not what we want, and it
causes flakniss. We can avoid that by using textarea instead.

BUG=651704
==========

to

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is needed, and it
causes flakniss.
We can avoid that by using textarea instead.

BUG=651704
==========

[yabinh, 2016-10-26 10:39:08]

Description was changed from

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is needed, and it
causes flakniss.
We can avoid that by using textarea instead.

BUG=651704
==========

to

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is needed, and it causes flakniss.
We can avoid that by using textarea instead.

BUG=651704
==========

[yabinh, 2016-10-26 10:39:29]

Description was changed from

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is needed, and it causes flakniss.
We can avoid that by using textarea instead.

BUG=651704
==========

to

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is needed, and it causes flakiness.
We can avoid that by using textarea instead.

BUG=651704
==========

[aelias_OOO_until_Jul13, 2016-10-26 18:26:27]

Description was changed from

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This is needed, and it causes flakiness.
We can avoid that by using textarea instead.

BUG=651704
==========

to

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This isn't needed, and it causes flakiness.
We can avoid that by using textarea instead.

BUG=651704
==========

[aelias_OOO_until_Jul13, 2016-10-26 18:28:48]

https://codereview.chromium.org/2447333003/diff/20001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/2447333003/diff/20001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:1464:
@RetryOnFailure
Please remove @RetryOnFailure if it's fully deflaked.

[Changwan Ryu, 2016-10-27 05:27:03]

On 2016/10/26 10:30:36, yabinh wrote:
> When ImeTest#commitText("\n") runs on input_text element, a blank tab will be
> open.  Also, ImeTest#commitText() will send a
ViewHostMsg_TextInputStateChanged
> message.It's a long call stack. It takes some time from opening the tab to
> sending the message.

Thanks for the investigation! I didn't expect that blank tab is being opened.
That's surprising...
Maybe a fix would be to run it on textarea or some other element that does not
submit the form?

> 
> 
> Case#1: If the time is long enough,
> InputMethodController#frame().selection().rootEditableElement() will be null,
> thus textInputInfo.type will be WebTextInputTypeNone. Later, when we update
the
> keyboard visibility, we will hide the keyboard and restart input. On doing
that,
> we will create an inputConnection unblocked on UI Thread. Since it's
unblocked,
> TextInputState#blockAndGetStateUpdate will return null. That's why
> getCursorCapsMode returns 0.
> 
> 
> Case#2: Sometimes, the time is short. Then
> InputMethodController#frame().selection().rootEditableElement() hasn't changed
> to be null, everything will be fine.
> 
> 
> If we don't open the blank tab, we can avoid the flakiness. Besides, opening a
> blank tab is not needed at the beginning.
> 
>
https://codereview.chromium.org/2447333003/diff/1/content/public/android/java...
> File
>
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
> (right):
> 
>
https://codereview.chromium.org/2447333003/diff/1/content/public/android/java...
>
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:1439:
> 
> Make sure Ime Thread is enabled.
> See https://bugs.chromium.org/p/chromium/issues/detail?id=648482#c5

[yabinh, 2016-10-27 05:39:11]

https://codereview.chromium.org/2447333003/diff/20001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/2447333003/diff/20001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:1464:
@RetryOnFailure
On 2016/10/26 18:28:48, aelias wrote:
> Please remove @RetryOnFailure if it's fully deflaked.

I think we'd better keep it for now because of the flakiness caused by screen
off. We can remove @RetryOnFailure after that is fixed. See
https://bugs.chromium.org/p/chromium/issues/detail?id=659869#c2

[yabinh, 2016-10-27 05:46:40]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 05:46:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-10-27 05:47:58]

https://codereview.chromium.org/2447333003/diff/20001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/2447333003/diff/20001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:1468:
clearEventLogs();
We don't need these 2 lines. So I removed it in patch set #3.

[Changwan Ryu, 2016-10-27 05:55:38]

lgtm

[commit-bot: I haz the power, 2016-10-27 06:08:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 06:08:05]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2016-10-27 06:21:19]

lgtm

[yabinh, 2016-10-27 06:35:41]

The CQ bit was checked by yabinh@chromium.org

[commit-bot: I haz the power, 2016-10-27 06:36:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 06:40:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-27 06:42:51]

Description was changed from

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This isn't needed, and it causes flakiness.
We can avoid that by using textarea instead.

BUG=651704
==========

to

==========
Fix flaky ImeTest#testGetCursorCapsMode

In ImeTest#testGetCursorCapsMode, when enter key is pressed on inputbox on
a phone, a blank tab will be opened. This isn't needed, and it causes flakiness.
We can avoid that by using textarea instead.

BUG=651704

Committed: https://crrev.com/7569ed80092216c303fb3838167583626c6ef03d
Cr-Commit-Position: refs/heads/master@{#427954}
==========

[commit-bot: I haz the power, 2016-10-27 06:42:52]

Patchset 3 (id:??) landed as
https://crrev.com/7569ed80092216c303fb3838167583626c6ef03d
Cr-Commit-Position: refs/heads/master@{#427954}