Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 24473002: Made session restore block about:flags driven browser restart. (Closed)

Created:
7 years, 3 months ago by zel
Modified:
7 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Made session restore block about:flags driven browser restart. This fixes a regression that's triggered by user password change where subsequent GAIA sign in flow wouldn't preserve OAuth2 refresh token anymore - see the BUG for more details. BUG=289965 TEST=manual R=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225294

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -16 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 1 2 8 chunks +70 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
zel
7 years, 3 months ago (2013-09-24 23:02:28 UTC) #1
xiyuan
LGTM
7 years, 3 months ago (2013-09-24 23:50:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/24473002/7001
7 years, 3 months ago (2013-09-25 01:05:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=158042
7 years, 3 months ago (2013-09-25 06:46:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/24473002/7001
7 years, 2 months ago (2013-09-25 14:50:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=158310
7 years, 2 months ago (2013-09-25 16:43:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/24473002/46001
7 years, 2 months ago (2013-09-25 22:44:30 UTC) #7
zel
7 years, 2 months ago (2013-09-26 01:11:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r225294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698