third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h - Issue 2447293002: Don't call lower() on KURL protocol/host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h

Issue 2447293002: Don't call lower() on KURL protocol/host (Closed)

Patch Set: add canonicalizeHost() as static method on SecurityOrigin and call from Document::setDomain Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h

diff --git a/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h b/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h

index d789b9ec22da9015f680dce64ea28965b3015a26..54d9e6d979247ebe80ecd613a6af36bf18fbd953 100644

--- a/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h

+++ b/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h

@@ -265,6 +265,10 @@ class PLATFORM_EXPORT SecurityOrigin : public RefCounted<SecurityOrigin> {

void setUniqueOriginIsPotentiallyTrustworthy(

bool isUniqueOriginPotentiallyTrustworthy);

+ // Only used for document.domain setting. The method should probably be moved

+ // if we need it for something more general.

+ static String canonicalizeHost(const String& host, bool* success);

private:

friend class SecurityOriginTest;

FRIEND_TEST_ALL_PREFIXES(SecurityOriginTest, Suborigins);