third_party/WebKit/Source/platform/weborigin/KURLTest.cpp - Issue 2447293002: Don't call lower() on KURL protocol/host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

Issue 2447293002: Don't call lower() on KURL protocol/host (Closed)

Patch Set: add canonicalizeHost() as static method on SecurityOrigin and call from Document::setDomain Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

diff --git a/third_party/WebKit/Source/platform/weborigin/KURLTest.cpp b/third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

index 68293cc5c825446cabe54e8648dffe927b823059..13cdda7e8d3df67f7cca018b38c393448108ba8c 100644

--- a/third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

+++ b/third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

@@ -700,6 +700,10 @@ TEST(KURLTest, ProtocolIs) {

KURL invalidUTF8(ParsedURLString, "http://a@9%aa%:");

EXPECT_FALSE(invalidUTF8.protocolIs("http"));

EXPECT_TRUE(invalidUTF8.protocolIs(""));

+ KURL capital(KURL(), "HTTP://www.example.text");

+ EXPECT_TRUE(capital.protocolIs("http"));

+ EXPECT_EQ(capital.protocol(), "http");

}

TEST(KURLTest, strippedForUseAsReferrer) {