Don't call lower() on KURL protocol/host

third_party/WebKit/Source/core/dom/Document.cpp

Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 324caf8eb8f7de97b3dda5d1b10fbd2ae0668579..15df76447f28e7854d1064552f99feab38a960f0 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -4403,7 +4403,10 @@ void Document::setDomain(const String& newDomain,
     return;
   }
 
-  OriginAccessEntry accessEntry(getSecurityOrigin()->protocol(), newDomain,
+  // TODO(csharrison): Should probably ensure newDomain is canonical rather than

[brettw, 2016/10/26 17:51:46]

definitely!

[Charlie Harrison, 2016/10/26 18:10:59]

Yes, it looks like we are missing step 4 here (parse the host):
https://html.spec.whatwg.org/multipage/browsers.html#dom-document-domain

Do you have a sense for how critical this error is? Can we fix it in a follow
up? I think there is no functionality in Blink to canonicalize hosts (there is a
anon function in SchemeHostPort that we will likely have to share).

+  // just lowercasing it.
+  OriginAccessEntry accessEntry(getSecurityOrigin()->protocol(),
+                                newDomain.lower(),
                                 OriginAccessEntry::AllowSubdomains);
   OriginAccessEntry::MatchResult result =
       accessEntry.matchesOrigin(*getSecurityOrigin());