third_party/WebKit/Source/platform/weborigin/KnownPorts.cpp - Issue 2447293002: Don't call lower() on KURL protocol/host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/weborigin/KnownPorts.cpp

Issue 2447293002: Don't call lower() on KURL protocol/host (Closed)

Patch Set: dont call protocol() / host() twice in SecurityOrigin constructor Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/weborigin/KnownPorts.cpp

diff --git a/third_party/WebKit/Source/platform/weborigin/KnownPorts.cpp b/third_party/WebKit/Source/platform/weborigin/KnownPorts.cpp

index 812fc30e30b514a4a417bfda0d8d7f36cfe80fba..7042f68813231ac0739aa3f2fabcf48c46931f19 100644

--- a/third_party/WebKit/Source/platform/weborigin/KnownPorts.cpp

+++ b/third_party/WebKit/Source/platform/weborigin/KnownPorts.cpp

@@ -69,7 +69,7 @@ bool isPortAllowedForScheme(const KURL& url) {

// through non-network schemes that don't go over the network.

if (!url.hasPort())

return true;

- String protocol = url.protocol().isNull() ? "" : url.protocol().lower();

+ String protocol = url.protocol().isNull() ? "" : url.protocol();

unsigned short effectivePort = url.port();

if (!effectivePort)

effectivePort = defaultPortForProtocol(protocol);