Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp

Issue 2447293002: Don't call lower() on KURL protocol/host (Closed)
Patch Set: add canonicalization layout test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp
diff --git a/third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp b/third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp
index c9ebd12e32a92cbb91c2428c43df62803c7c4ab5..e81efeaefba02a64f4698b5bfde6a4fce1e51c22 100644
--- a/third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp
+++ b/third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp
@@ -78,8 +78,8 @@ bool IsSubdomainOfHost(const String& subdomain, const String& host) {
OriginAccessEntry::OriginAccessEntry(const String& protocol,
const String& host,
SubdomainSetting subdomainSetting)
- : m_protocol(protocol.lower()),
- m_host(host.lower()),
+ : m_protocol(protocol),
+ m_host(host),
m_subdomainSettings(subdomainSetting),
m_hostIsPublicSuffix(false) {
ASSERT(subdomainSetting >= AllowSubdomains ||
@@ -112,8 +112,6 @@ OriginAccessEntry::OriginAccessEntry(const String& protocol,
OriginAccessEntry::MatchResult OriginAccessEntry::matchesOrigin(
const SecurityOrigin& origin) const {
- ASSERT(origin.protocol() == origin.protocol().lower());
-
if (m_protocol != origin.protocol())
return DoesNotMatchOrigin;
@@ -122,7 +120,6 @@ OriginAccessEntry::MatchResult OriginAccessEntry::matchesOrigin(
OriginAccessEntry::MatchResult OriginAccessEntry::matchesDomain(
const SecurityOrigin& origin) const {
- ASSERT(origin.host() == origin.host().lower());
// Special case: Include subdomains and empty host means "all hosts, including
// ip addresses".
if (m_subdomainSettings != DisallowSubdomains && m_host.isEmpty())

Powered by Google App Engine
This is Rietveld 408576698