appengine/predator/app/common/model/crash_analysis.py - Issue 2447253002: [Findit & Predator] Code reorg of Findit.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/predator/app/common/model/crash_analysis.py

Issue 2447253002: [Findit & Predator] Code reorg of Findit. (Closed)

Patch Set: Clean up. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 from google.appengine.ext import ndb
	Sharu Jiang 2016/11/04 18:39:46 So the common/ here is for things shared by fracas So the common/ here is for things shared by fracas/cracas/clusterfuzz? It seems a little too fine-grained. If we do this to model, should we also do this to handler and template? stgao 2016/11/08 18:53:32 These are the models/etc that have to be shared be Show quoted text On 2016/11/04 18:39:46, Sharu Jiang wrote: > So the common/ here is for things shared by fracas/cracas/clusterfuzz? It seems > a little too fine-grained. If we do this to model, should we also do this to > handler and template? These are the models/etc that have to be shared between the frontend and backend.
	2

	3 from gae_libs.model import versioned_model

	4

	5 class CrashAnalysis(versioned_model.VersionedModel):

	6 signature = ndb.StringProperty(indexed=False)

	7

	8 stacktrace = ndb.StringProperty(indexed=False)

	9

	10 @classmethod

	11 def CreateKey(cls, signature):

	12 return ndb.Key(cls, signature)

	13

	14 @classmethod

	15 def Create(cls, signature):

	16 return cls(key=cls.CreateKey(signature), signature=signature)

	17

	18 @classmethod

	19 def Get(cls, signature):

	20 return cls.CreateKey(signature).get()

OLD	NEW