Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: base/test/parallel_test_launcher.cc

Issue 24472002: GTTF: Make temp file deletion failures non-fatal on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/parallel_test_launcher.cc
diff --git a/base/test/parallel_test_launcher.cc b/base/test/parallel_test_launcher.cc
index 7fc5f652531c7ec04faf7f64e8e111d5abeb2f05..0883946bb6f39aa06a9d7e4b238ab84f6685c240 100644
--- a/base/test/parallel_test_launcher.cc
+++ b/base/test/parallel_test_launcher.cc
@@ -110,7 +110,10 @@ void DoLaunchChildTestProcess(
std::string output_file_contents;
CHECK(base::ReadFileToString(output_file, &output_file_contents));
- CHECK(base::DeleteFile(output_file, false));
+ if (!base::DeleteFile(output_file, false)) {
+ // This needs to be non-fatal at least for Windows.
+ LOG(WARNING) << "Failed to delete " << output_file.AsUTF8Unsafe();
+ }
// Run target callback on the thread it was originating from, not on
// a worker pool thread.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698