Refactor network_time_test_utils

Refactor network_time_test_utils

This CL refactors network_time_test_utils in preparation for enabling
on-demand time fetches when a DATE_INVALID certificate error is
encountered.

The changes are:

1. Make FieldTrialTest no longer inherit from ::testing::Test, so that
it can be used compositionally in tests that subclass
e.g. RenderViewHostTestHarness. (A follow-up CL will use a
FieldTrialTest inside a RenderViewHostTestHarness test.)

2. Add an argument to enable on-demand fetches to
SetNetworkQueriesWithVariationsService(). This param is not yet used
anywhere but will be in follow-up CLs.

3. Move GoodTimeResponseHandler from network_time_tracker_unittest.cc to
network_time_test_utils.h/.cc. A follow-up CL will use this response
handler to test on-demand time fetches outside of
network_time_tracker_unittest.cc.

This is a series of patches to add on-demand time fetches when handling
cert date invalid errors.
CL #1: https://codereview.chromium.org/2447183002/ <== this one
CL #2: https://codereview.chromium.org/2453523002/
CL #3: https://codereview.chromium.org/2449193002/

BUG=589700
Committed: https://crrev.com/9cf4bc9f98b73736007663f037b9f1fed67a75b6
Cr-Commit-Position: refs/heads/master@{#427551}

[estark, 2016-10-25 18:30:15]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:30:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:35:30]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[estark, 2016-10-25 18:44:14]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:44:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:48:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[estark, 2016-10-25 18:51:03]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:51:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 19:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 19:56:27]

Dry run: This issue passed the CQ dry run.

[estark, 2016-10-25 20:11:27]

Description was changed from

==========
Refactor network_time_test_utils

This CL refactors network_time_test_utils in preparation for enabling
on-demand time fetches when a DATE_INVALID certificate error is
encountered.

The changes are:

1. Make FieldTrialTest no longer inherit from ::testing::Test, so that
it can be used compositionally in tests that subclass
e.g. RenderViewHostTestHarness. (A follow-up CL will use a
FieldTrialTest inside a RenderViewHostTestHarness test.)

2. Add an argument to enable on-demand fetches to
SetNetworkQueriesWithVariationsService(). This param is not yet used
anywhere but will be in follow-up CLs.

3. Move GoodTimeResponseHandler from network_time_tracker_unittest.cc to
network_time_test_utils.h/.cc. A follow-up CL will use this response
handler to test on-demand time fetches outside of
network_time_tracker_unittest.cc.

BUG=589700
==========

to

==========
Refactor network_time_test_utils

This CL refactors network_time_test_utils in preparation for enabling
on-demand time fetches when a DATE_INVALID certificate error is
encountered.

The changes are:

1. Make FieldTrialTest no longer inherit from ::testing::Test, so that
it can be used compositionally in tests that subclass
e.g. RenderViewHostTestHarness. (A follow-up CL will use a
FieldTrialTest inside a RenderViewHostTestHarness test.)

2. Add an argument to enable on-demand fetches to
SetNetworkQueriesWithVariationsService(). This param is not yet used
anywhere but will be in follow-up CLs.

3. Move GoodTimeResponseHandler from network_time_tracker_unittest.cc to
network_time_test_utils.h/.cc. A follow-up CL will use this response
handler to test on-demand time fetches outside of
network_time_tracker_unittest.cc.

This is a series of patches to add on-demand time fetches when handling
cert date invalid errors.
CL #1: https://codereview.chromium.org/2447183002/ <== this one
CL #2: https://codereview.chromium.org/2453523002/
CL #3: https://codereview.chromium.org/2449193002/

BUG=589700
==========

[estark, 2016-10-25 20:13:10]

estark@chromium.org changed reviewers:
+ meacer@chromium.org

[estark, 2016-10-25 20:13:10]

meacer, I'm going to be sending you a series of patches (this is the first of
three) to do on-demand time fetches when network time is unavailable when we
encounter a cert date invalid error. I'd like to experiment with this approach
on canary to see if it gets better results, because right now we don't have
network time available on ~25% of cert date invalid errors.

Thanks!

[meacer, 2016-10-26 00:19:04]

On 2016/10/25 20:13:10, estark wrote:
> meacer, I'm going to be sending you a series of patches (this is the first of
> three) to do on-demand time fetches when network time is unavailable when we
> encounter a cert date invalid error. I'd like to experiment with this approach
> on canary to see if it gets better results, because right now we don't have
> network time available on ~25% of cert date invalid errors.
> 
> Thanks!

Lgtm. Thanks for the detailed description.

[estark, 2016-10-26 00:22:54]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-10-26 00:23:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 00:31:00]

Description was changed from

==========
Refactor network_time_test_utils

This CL refactors network_time_test_utils in preparation for enabling
on-demand time fetches when a DATE_INVALID certificate error is
encountered.

The changes are:

1. Make FieldTrialTest no longer inherit from ::testing::Test, so that
it can be used compositionally in tests that subclass
e.g. RenderViewHostTestHarness. (A follow-up CL will use a
FieldTrialTest inside a RenderViewHostTestHarness test.)

2. Add an argument to enable on-demand fetches to
SetNetworkQueriesWithVariationsService(). This param is not yet used
anywhere but will be in follow-up CLs.

3. Move GoodTimeResponseHandler from network_time_tracker_unittest.cc to
network_time_test_utils.h/.cc. A follow-up CL will use this response
handler to test on-demand time fetches outside of
network_time_tracker_unittest.cc.

This is a series of patches to add on-demand time fetches when handling
cert date invalid errors.
CL #1: https://codereview.chromium.org/2447183002/ <== this one
CL #2: https://codereview.chromium.org/2453523002/
CL #3: https://codereview.chromium.org/2449193002/

BUG=589700
==========

to

==========
Refactor network_time_test_utils

This CL refactors network_time_test_utils in preparation for enabling
on-demand time fetches when a DATE_INVALID certificate error is
encountered.

The changes are:

1. Make FieldTrialTest no longer inherit from ::testing::Test, so that
it can be used compositionally in tests that subclass
e.g. RenderViewHostTestHarness. (A follow-up CL will use a
FieldTrialTest inside a RenderViewHostTestHarness test.)

2. Add an argument to enable on-demand fetches to
SetNetworkQueriesWithVariationsService(). This param is not yet used
anywhere but will be in follow-up CLs.

3. Move GoodTimeResponseHandler from network_time_tracker_unittest.cc to
network_time_test_utils.h/.cc. A follow-up CL will use this response
handler to test on-demand time fetches outside of
network_time_tracker_unittest.cc.

This is a series of patches to add on-demand time fetches when handling
cert date invalid errors.
CL #1: https://codereview.chromium.org/2447183002/ <== this one
CL #2: https://codereview.chromium.org/2453523002/
CL #3: https://codereview.chromium.org/2449193002/

BUG=589700
==========

[commit-bot: I haz the power, 2016-10-26 00:31:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 00:34:14]

Description was changed from

==========
Refactor network_time_test_utils

This CL refactors network_time_test_utils in preparation for enabling
on-demand time fetches when a DATE_INVALID certificate error is
encountered.

The changes are:

1. Make FieldTrialTest no longer inherit from ::testing::Test, so that
it can be used compositionally in tests that subclass
e.g. RenderViewHostTestHarness. (A follow-up CL will use a
FieldTrialTest inside a RenderViewHostTestHarness test.)

2. Add an argument to enable on-demand fetches to
SetNetworkQueriesWithVariationsService(). This param is not yet used
anywhere but will be in follow-up CLs.

3. Move GoodTimeResponseHandler from network_time_tracker_unittest.cc to
network_time_test_utils.h/.cc. A follow-up CL will use this response
handler to test on-demand time fetches outside of
network_time_tracker_unittest.cc.

This is a series of patches to add on-demand time fetches when handling
cert date invalid errors.
CL #1: https://codereview.chromium.org/2447183002/ <== this one
CL #2: https://codereview.chromium.org/2453523002/
CL #3: https://codereview.chromium.org/2449193002/

BUG=589700
==========

to

==========
Refactor network_time_test_utils

This CL refactors network_time_test_utils in preparation for enabling
on-demand time fetches when a DATE_INVALID certificate error is
encountered.

The changes are:

1. Make FieldTrialTest no longer inherit from ::testing::Test, so that
it can be used compositionally in tests that subclass
e.g. RenderViewHostTestHarness. (A follow-up CL will use a
FieldTrialTest inside a RenderViewHostTestHarness test.)

2. Add an argument to enable on-demand fetches to
SetNetworkQueriesWithVariationsService(). This param is not yet used
anywhere but will be in follow-up CLs.

3. Move GoodTimeResponseHandler from network_time_tracker_unittest.cc to
network_time_test_utils.h/.cc. A follow-up CL will use this response
handler to test on-demand time fetches outside of
network_time_tracker_unittest.cc.

This is a series of patches to add on-demand time fetches when handling
cert date invalid errors.
CL #1: https://codereview.chromium.org/2447183002/ <== this one
CL #2: https://codereview.chromium.org/2453523002/
CL #3: https://codereview.chromium.org/2449193002/

BUG=589700

Committed: https://crrev.com/9cf4bc9f98b73736007663f037b9f1fed67a75b6
Cr-Commit-Position: refs/heads/master@{#427551}
==========

[commit-bot: I haz the power, 2016-10-26 00:34:15]

Patchset 3 (id:??) landed as
https://crrev.com/9cf4bc9f98b73736007663f037b9f1fed67a75b6
Cr-Commit-Position: refs/heads/master@{#427551}